Commit 3fccfa56 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: adp5585: use new line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20250303-gpiochip-set-conversion-v1-6-1d5cceeebf8b@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 8a9bc5a5

drivers/gpio/gpio-adp5585.c

+6 −4
Original line number Diff line number Diff line
@@ -86,13 +86,15 @@ static int adp5585_gpio_get_value(struct gpio_chip *chip, unsigned int off) 
	return !!(val & bit);

}



static void adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off, int val)

static int adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off,

				  int val)

{

	struct adp5585_gpio_dev *adp5585_gpio = gpiochip_get_data(chip);

	unsigned int bank = ADP5585_BANK(off);

	unsigned int bit = ADP5585_BIT(off);



	regmap_update_bits(adp5585_gpio->regmap, ADP5585_GPO_DATA_OUT_A + bank,

	return regmap_update_bits(adp5585_gpio->regmap,

				  ADP5585_GPO_DATA_OUT_A + bank,

				  bit, val ? bit : 0);

}
@@ -192,7 +194,7 @@ static int adp5585_gpio_probe(struct platform_device *pdev) 
	gc->direction_input = adp5585_gpio_direction_input;

	gc->direction_output = adp5585_gpio_direction_output;

	gc->get = adp5585_gpio_get_value;

	gc->set = adp5585_gpio_set_value;

	gc->set_rv = adp5585_gpio_set_value;

	gc->set_config = adp5585_gpio_set_config;

	gc->can_sleep = true;