Commit 3fe5a2b9 authored by Shresth Prasad's avatar Shresth Prasad Committed by Rob Herring (Arm)
Browse files

of: property: Use scope based cleanup on port_node 



Use __free cleanup handler which ensures that the resource is freed when
it goes out of scope, thus removing the need to manually clean it up
using of_node_put.

Suggested-by: default avatarJulia Lawall <julia.lawall@inria.fr>
Signed-off-by: default avatarShresth Prasad <shresthprasad7@gmail.com>
Link: https://lore.kernel.org/r/20240428115226.41345-2-shresthprasad7@gmail.com


Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent c56436ef

drivers/of/property.c

+2 −3
Original line number Diff line number Diff line
@@ -576,7 +576,8 @@ EXPORT_SYMBOL_GPL(of_prop_next_string); 
int of_graph_parse_endpoint(const struct device_node *node,

			    struct of_endpoint *endpoint)

{

	struct device_node *port_node = of_get_parent(node);

	struct device_node *port_node __free(device_node) =

			    of_get_parent(node);



	WARN_ONCE(!port_node, "%s(): endpoint %pOF has no parent node\n",

		  __func__, node);
@@ -591,8 +592,6 @@ int of_graph_parse_endpoint(const struct device_node *node, 
	of_property_read_u32(port_node, "reg", &endpoint->port);

	of_property_read_u32(node, "reg", &endpoint->id);



	of_node_put(port_node);



	return 0;

}

EXPORT_SYMBOL(of_graph_parse_endpoint);