Commit 401a8e9e authored by Wolfram Sang's avatar Wolfram Sang Committed by Andi Shyti
Browse files

i2c: mpc: use proper binding for transfer timeouts 



"i2c-scl-clk-low-timeout-us" is wrongly used here because it describes
maximum clock stretching not maximum transfer time. Additionally, it is
deprecated because of issues. Move this driver to the correct binding.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarChris Packham <chris.packham@alliedtelesis.co.nz>
Tested-by: default avatarChris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent f9ccb453

drivers/i2c/busses/i2c-mpc.c

+6 −6
Original line number Diff line number Diff line
@@ -844,11 +844,11 @@ static int fsl_i2c_probe(struct platform_device *op) 
			mpc_i2c_setup_8xxx(op->dev.of_node, i2c, clock);

	}



	/*

	 * "fsl,timeout" has been marked as deprecated and, to maintain

	 * backward compatibility, we will only look for it if

	 * "i2c-scl-clk-low-timeout-us" is not present.

	 */

	/* Sadly, we have to support two deprecated bindings here */

	result = of_property_read_u32(op->dev.of_node,

				      "i2c-transfer-timeout-us",

				      &mpc_ops.timeout);

	if (result == -EINVAL)

		result = of_property_read_u32(op->dev.of_node,

					      "i2c-scl-clk-low-timeout-us",

					      &mpc_ops.timeout);