Commit 4022ba20 authored by Thorsten Blum's avatar Thorsten Blum Committed by Andrew Morton
Browse files

ocfs2: replace deprecated strcpy in ocfs2_create_xattr_block 

strcpy() has been deprecated [1] because it performs no bounds checking on
the destination buffer, which can lead to buffer overflows.  Replace it
with the safer strscpy(), and copy directly into '->xb_signature' instead
of using the start of the struct as the destination buffer.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Link: https://lkml.kernel.org/r/20251118185345.132411-2-thorsten.blum@linux.dev


Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarJoseph Qi <joseph.qi@linux.alibaba.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent ff713698

fs/ocfs2/xattr.c

+1 −1
Original line number Diff line number Diff line
@@ -2908,7 +2908,7 @@ static int ocfs2_create_xattr_block(struct inode *inode, 
	/* Initialize ocfs2_xattr_block */

	xblk = (struct ocfs2_xattr_block *)new_bh->b_data;

	memset(xblk, 0, inode->i_sb->s_blocksize);

	strcpy((void *)xblk, OCFS2_XATTR_BLOCK_SIGNATURE);

	strscpy(xblk->xb_signature, OCFS2_XATTR_BLOCK_SIGNATURE);

	xblk->xb_suballoc_slot = cpu_to_le16(ctxt->meta_ac->ac_alloc_slot);

	xblk->xb_suballoc_loc = cpu_to_le64(suballoc_loc);

	xblk->xb_suballoc_bit = cpu_to_le16(suballoc_bit_start);