Commit 403889c0 authored by Kinglong Mee's avatar Kinglong Mee Committed by Trond Myklebust
Browse files

NFS: Fix bad checking of max taglen in callback request 



The taglen should be checked with CB_OP_TAGLEN_MAXSZ directly.

Signed-off-by: default avatarKinglong Mee <kinglongmee@gmail.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 45724e8a

fs/nfs/callback_xdr.c

+1 −1
Original line number Diff line number Diff line
@@ -159,7 +159,7 @@ static __be32 decode_compound_hdr_arg(struct xdr_stream *xdr, struct cb_compound 
	if (unlikely(status != 0))

		return status;

	/* We do not like overly long tags! */

	if (hdr->taglen > CB_OP_TAGLEN_MAXSZ - 12) {

	if (hdr->taglen > CB_OP_TAGLEN_MAXSZ) {

		printk("NFS: NFSv4 CALLBACK %s: client sent tag of length %u\n",

				__func__, hdr->taglen);

		return htonl(NFS4ERR_RESOURCE);