Commit 40488cc1 authored by Stefan Hajnoczi's avatar Stefan Hajnoczi Committed by Miklos Szeredi
Browse files

virtiofs: forbid newlines in tags 



Newlines in virtiofs tags are awkward for users and potential vectors
for string injection attacks.

Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarVivek Goyal <vgoyal@redhat.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent b401b621

fs/fuse/virtio_fs.c

+10 −0
Original line number Diff line number Diff line
@@ -323,6 +323,16 @@ static int virtio_fs_read_tag(struct virtio_device *vdev, struct virtio_fs *fs) 
		return -ENOMEM;

	memcpy(fs->tag, tag_buf, len);

	fs->tag[len] = '\0';



	/* While the VIRTIO specification allows any character, newlines are

	 * awkward on mount(8) command-lines and cause problems in the sysfs

	 * "tag" attr and uevent TAG= properties. Forbid them.

	 */

	if (strchr(fs->tag, '\n')) {

		dev_dbg(&vdev->dev, "refusing virtiofs tag with newline character\n");

		return -EINVAL;

	}



	return 0;

}