Commit 405ee409 authored by Nandor Kracser's avatar Nandor Kracser Committed by Steve French
Browse files

ksmbd: ignore trailing slashes in share paths 



Trailing slashes in share paths (like: /home/me/Share/) caused permission
issues with shares for clients on iOS and on Android TV for me,
but otherwise they work fine with plain old Samba.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarNandor Kracser <bonifaido@gmail.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent c91ecba9

fs/smb/server/mgmt/share_config.c

+5 −1
Original line number Diff line number Diff line
@@ -165,8 +165,12 @@ static struct ksmbd_share_config *share_config_request(struct unicode_map *um, 


		share->path = kstrndup(ksmbd_share_config_path(resp), path_len,

				      GFP_KERNEL);

		if (share->path)

		if (share->path) {

			share->path_sz = strlen(share->path);

			while (share->path_sz > 1 &&

			       share->path[share->path_sz - 1] == '/')

				share->path[--share->path_sz] = '\0';

		}

		share->create_mask = resp->create_mask;

		share->directory_mask = resp->directory_mask;

		share->force_create_mode = resp->force_create_mode;