Unverified Commit 40761250 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/tidss: Convert to drm logging 



DRM drivers should prefer the drm logging functions to the dev logging
ones when possible. Let's convert the existing dev_* logs to their drm
counterparts.

Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250902-drm-state-readout-v1-18-14ad5315da3f@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20250902-drm-state-readout-v1-18-14ad5315da3f@kernel.org
parent 0359a849

drivers/gpu/drm/tidss/tidss_crtc.c

+2 −2
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ static int tidss_crtc_atomic_check(struct drm_crtc *crtc, 


	ok = dispc_vp_mode_valid(dispc, hw_videoport, mode);

	if (ok != MODE_OK) {

		dev_dbg(ddev->dev, "%s: bad mode: %ux%u pclk %u kHz\n",

		drm_dbg(ddev, "%s: bad mode: %ux%u pclk %u kHz\n",

			__func__, mode->hdisplay, mode->vdisplay, mode->clock);

		return -EINVAL;

	}
@@ -172,7 +172,7 @@ static void tidss_crtc_atomic_flush(struct drm_crtc *crtc, 
	struct tidss_device *tidss = to_tidss(ddev);

	unsigned long flags;



	dev_dbg(ddev->dev, "%s: %s is %sactive, %s modeset, event %p\n",

	drm_dbg(ddev, "%s: %s is %sactive, %s modeset, event %p\n",

		__func__, crtc->name, crtc->state->active ? "" : "not ",

		drm_atomic_crtc_needs_modeset(crtc->state) ? "needs" : "doesn't need",

		crtc->state->event);

drivers/gpu/drm/tidss/tidss_dispc.c

+4 −2
Original line number Diff line number Diff line
@@ -1051,20 +1051,22 @@ struct dispc_bus_format *dispc_vp_find_bus_fmt(struct dispc_device *dispc, 
int dispc_vp_bus_check(struct dispc_device *dispc, u32 hw_videoport,

		       const struct drm_crtc_state *state)

{

	struct tidss_device *tidss = dispc->tidss;

	struct drm_device *dev = &tidss->ddev;

	const struct tidss_crtc_state *tstate = to_tidss_crtc_state(state);

	const struct dispc_bus_format *fmt;



	fmt = dispc_vp_find_bus_fmt(dispc, hw_videoport, tstate->bus_format,

				    tstate->bus_flags);

	if (!fmt) {

		dev_dbg(dispc->dev, "%s: Unsupported bus format: %u\n",

		drm_dbg(dev, "%s: Unsupported bus format: %u\n",

			__func__, tstate->bus_format);

		return -EINVAL;

	}



	if (dispc->feat->vp_bus_type[hw_videoport] != DISPC_VP_OLDI_AM65X &&

	    fmt->is_oldi_fmt) {

		dev_dbg(dispc->dev, "%s: %s is not OLDI-port\n",

		drm_dbg(dev, "%s: %s is not OLDI-port\n",

			__func__, dispc->feat->vp_name[hw_videoport]);

		return -EINVAL;

	}