Commit 40c97482 authored by Vitalii Mordan's avatar Vitalii Mordan Committed by Greg Kroah-Hartman
Browse files

usb: ehci-spear: fix call balance of sehci clk handling routines 



If the clock sehci->clk was not enabled in spear_ehci_hcd_drv_probe,
it should not be disabled in any path.

Conversely, if it was enabled in spear_ehci_hcd_drv_probe, it must be disabled
in all error paths to ensure proper cleanup.

Found by Linux Verification Center (linuxtesting.org) with Klever.

Fixes: 7675d6ba ("USB: EHCI: make ehci-spear a separate driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarVitalii Mordan <mordan@ispras.ru>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20241114230310.432213-1-mordan@ispras.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aa03bda6

drivers/usb/host/ehci-spear.c

+4 −3
Original line number Diff line number Diff line
@@ -105,7 +105,9 @@ static int spear_ehci_hcd_drv_probe(struct platform_device *pdev) 
	/* registers start at offset 0x0 */

	hcd_to_ehci(hcd)->caps = hcd->regs;



	clk_prepare_enable(sehci->clk);

	retval = clk_prepare_enable(sehci->clk);

	if (retval)

		goto err_put_hcd;

	retval = usb_add_hcd(hcd, irq, IRQF_SHARED);

	if (retval)

		goto err_stop_ehci;
@@ -130,7 +132,6 @@ static void spear_ehci_hcd_drv_remove(struct platform_device *pdev) 


	usb_remove_hcd(hcd);



	if (sehci->clk)

	clk_disable_unprepare(sehci->clk);

	usb_put_hcd(hcd);

}