Commit 40e171c2 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Vinod Koul
Browse files

dmaengine: use sysfs_emit() to instead of scnprintf() 



Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230130111141.59627-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 8b544310

drivers/dma/dmaengine.c

+3 −3
Original line number Diff line number Diff line
@@ -172,7 +172,7 @@ static ssize_t memcpy_count_show(struct device *dev, 
	if (chan) {

		for_each_possible_cpu(i)

			count += per_cpu_ptr(chan->local, i)->memcpy_count;

		err = sprintf(buf, "%lu\n", count);

		err = sysfs_emit(buf, "%lu\n", count);

	} else

		err = -ENODEV;

	mutex_unlock(&dma_list_mutex);
@@ -194,7 +194,7 @@ static ssize_t bytes_transferred_show(struct device *dev, 
	if (chan) {

		for_each_possible_cpu(i)

			count += per_cpu_ptr(chan->local, i)->bytes_transferred;

		err = sprintf(buf, "%lu\n", count);

		err = sysfs_emit(buf, "%lu\n", count);

	} else

		err = -ENODEV;

	mutex_unlock(&dma_list_mutex);
@@ -212,7 +212,7 @@ static ssize_t in_use_show(struct device *dev, struct device_attribute *attr, 
	mutex_lock(&dma_list_mutex);

	chan = dev_to_dma_chan(dev);

	if (chan)

		err = sprintf(buf, "%d\n", chan->client_count);

		err = sysfs_emit(buf, "%d\n", chan->client_count);

	else

		err = -ENODEV;

	mutex_unlock(&dma_list_mutex);