Commit 40eb655b authored by SeongJae Park's avatar SeongJae Park Committed by Andrew Morton
Browse files

mm/damon/core: do not call damos_walk_control->walk() if walk is completed 

damos_walk() invokes callback functions of schemes until all schemes
finishes at least one round of walks.  If there are multiple DAMOS schemes
having different apply_interval, the callback functions for longer apply
interval scheme will be called for more than a round of the walk.

The behavior is different from the document (see damos_walk() kernel-doc
comment), and not useful.  Make the behavior be same to the documented
one, by stopping invoking the callback if the walk for the given scheme is
completed.

Link: https://lkml.kernel.org/r/20250210182737.134994-3-sj@kernel.org


Fixes: bf0eaba0 ("mm/damon/core: implement damos_walk()")
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c32696ca

mm/damon/core.c

+3 −0
Original line number Diff line number Diff line
@@ -1458,6 +1458,9 @@ static void damos_walk_call_walk(struct damon_ctx *ctx, struct damon_target *t, 
{

	struct damos_walk_control *control;



	if (s->walk_completed)

		return;



	mutex_lock(&ctx->walk_control_lock);

	control = ctx->walk_control;

	mutex_unlock(&ctx->walk_control_lock);