Unverified Commit 40ee63f5 authored by Vinay Belgaumkar's avatar Vinay Belgaumkar Committed by Rodrigo Vivi
Browse files

drm/xe/ptl: Disable DCC on PTL 



On PTL, the recommendation is to disable DCC(Duty Cycle Control) as
it may cause some regressions due to added latencies. Upcoming GuC
releases will disable DCC on PTL as well, but we need to force it in
KMD so that this behavior is propagated to older kernels.

v2: Update commit message (Rodrigo)
v3: Rebase
v4: Fix typo: s/propagted/propagated

Fixes: 5cdb71d3 ("drm/xe/ptl: Add GuC FW definition for PTL")
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarVinay Belgaumkar <vinay.belgaumkar@intel.com>
Link: https://patch.msgid.link/20260124005917.398522-1-vinay.belgaumkar@intel.com


Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 7fe6cae2

drivers/gpu/drm/xe/xe_guc_pc.c

+34 −0
Original line number Diff line number Diff line
@@ -1198,6 +1198,36 @@ int xe_guc_pc_set_power_profile(struct xe_guc_pc *pc, const char *buf) 
	return ret;

}



static int pc_action_set_dcc(struct xe_guc_pc *pc, bool enable)

{

	int ret;



	ret = pc_action_set_param(pc,

				  SLPC_PARAM_TASK_ENABLE_DCC,

				  enable);

	if (!ret)

		return pc_action_set_param(pc,

					   SLPC_PARAM_TASK_DISABLE_DCC,

					   !enable);

	else

		return ret;

}



static int pc_modify_defaults(struct xe_guc_pc *pc)

{

	struct xe_device *xe = pc_to_xe(pc);

	struct xe_gt *gt = pc_to_gt(pc);

	int ret = 0;



	if (xe->info.platform == XE_PANTHERLAKE) {

		ret = pc_action_set_dcc(pc, false);

		if (unlikely(ret))

			xe_gt_err(gt, "Failed to modify DCC default: %pe\n", ERR_PTR(ret));

	}



	return ret;

}



/**

 * xe_guc_pc_start - Start GuC's Power Conservation component

 * @pc: Xe_GuC_PC instance
@@ -1249,6 +1279,10 @@ int xe_guc_pc_start(struct xe_guc_pc *pc) 
			   ktime_ms_delta(ktime_get(), earlier));

	}



	ret = pc_modify_defaults(pc);

	if (ret)

		return ret;



	ret = pc_init_freqs(pc);

	if (ret)

		return ret;