Unverified Commit 41399c5d authored by Guodong Xu's avatar Guodong Xu Committed by Mark Brown
Browse files

regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators 

Higher voltage settings were unusable due to incorrect n_voltages values
causing registration failures. For example, setting aldo4 to 3.3V failed
with -EINVAL because the required selector (123) exceeded the allowed
range (n_voltages=117).

Fix by aligning n_voltages with the hardware register widths per the P1
datasheet [1]:
- BUCK: 255 (was 254), allows selectors 0-254, selector 255 is reserved
- LDO: 128 (was 117), allows selectors 0-127, selectors 0-10 are for
  suspend mode, valid operational range is 11-127

This enables the full voltage range supported by the hardware.

Fixes: 8b84d712 ("regulator: spacemit: support SpacemiT P1 regulators")
Link: https://developer.spacemit.com/documentation

 [1]
Signed-off-by: default avatarGuodong Xu <guodong@riscstar.com>
Link: https://patch.msgid.link/20260122-spacemit-p1-v1-1-309be27fbff9@riscstar.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 63804fed

drivers/regulator/spacemit-p1.c

+3 −3
Original line number Diff line number Diff line
@@ -87,13 +87,13 @@ static const struct linear_range p1_ldo_ranges[] = { 
	}



#define P1_BUCK_DESC(_n) \

	P1_REG_DESC(BUCK, buck, _n, "vin", 0x47, BUCK_MASK, 254, p1_buck_ranges)

	P1_REG_DESC(BUCK, buck, _n, "vin", 0x47, BUCK_MASK, 255, p1_buck_ranges)



#define P1_ALDO_DESC(_n) \

	P1_REG_DESC(ALDO, aldo, _n, "vin", 0x5b, LDO_MASK, 117, p1_ldo_ranges)

	P1_REG_DESC(ALDO, aldo, _n, "vin", 0x5b, LDO_MASK, 128, p1_ldo_ranges)



#define P1_DLDO_DESC(_n) \

	P1_REG_DESC(DLDO, dldo, _n, "buck5", 0x67, LDO_MASK, 117, p1_ldo_ranges)

	P1_REG_DESC(DLDO, dldo, _n, "buck5", 0x67, LDO_MASK, 128, p1_ldo_ranges)



static const struct regulator_desc p1_regulator_desc[] = {

	P1_BUCK_DESC(1),