Commit 414c4eb5 authored by Jouni Högander's avatar Jouni Högander
Browse files

drm/i915/display: Use intel_attached_dp instead of local implementation 



Link training code contains local "connector to intel_dp"
implementation. This was added due to missing MST handling in
intel_attached_dp. Missing MST support is now fixed in
intel_attached_dp. We can now change link training code to use that instead
of local intel_connector_to_intel_dp.

Signed-off-by: default avatarJouni Högander <jouni.hogander@intel.com>
Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240906070033.289015-3-jouni.hogander@intel.com
parent 12f01766

drivers/gpu/drm/i915/display/intel_dp_link_training.c

+11 −19
Original line number Diff line number Diff line
@@ -1681,19 +1681,11 @@ void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp, 
	lt_dbg(intel_dp, DP_PHY_DPRX, "DP2.0 SDP CRC16 for 128b/132b enabled\n");

}



static struct intel_dp *intel_connector_to_intel_dp(struct intel_connector *connector)

{

	if (connector->mst_port)

		return connector->mst_port;

	else

		return enc_to_intel_dp(intel_attached_encoder(connector));

}



static int i915_dp_force_link_rate_show(struct seq_file *m, void *data)

{

	struct intel_connector *connector = to_intel_connector(m->private);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int current_rate = -1;

	int force_rate;

	int err;
@@ -1764,7 +1756,7 @@ static ssize_t i915_dp_force_link_rate_write(struct file *file, 
	struct seq_file *m = file->private_data;

	struct intel_connector *connector = to_intel_connector(m->private);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int rate;

	int err;
@@ -1791,7 +1783,7 @@ static int i915_dp_force_lane_count_show(struct seq_file *m, void *data) 
{

	struct intel_connector *connector = to_intel_connector(m->private);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int current_lane_count = -1;

	int force_lane_count;

	int err;
@@ -1866,7 +1858,7 @@ static ssize_t i915_dp_force_lane_count_write(struct file *file, 
	struct seq_file *m = file->private_data;

	struct intel_connector *connector = to_intel_connector(m->private);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int lane_count;

	int err;
@@ -1893,7 +1885,7 @@ static int i915_dp_max_link_rate_show(void *data, u64 *val) 
{

	struct intel_connector *connector = to_intel_connector(data);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int err;



	err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex);
@@ -1912,7 +1904,7 @@ static int i915_dp_max_lane_count_show(void *data, u64 *val) 
{

	struct intel_connector *connector = to_intel_connector(data);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int err;



	err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex);
@@ -1931,7 +1923,7 @@ static int i915_dp_force_link_training_failure_show(void *data, u64 *val) 
{

	struct intel_connector *connector = to_intel_connector(data);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int err;



	err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex);
@@ -1949,7 +1941,7 @@ static int i915_dp_force_link_training_failure_write(void *data, u64 val) 
{

	struct intel_connector *connector = to_intel_connector(data);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int err;



	if (val > 2)
@@ -1973,7 +1965,7 @@ static int i915_dp_force_link_retrain_show(void *data, u64 *val) 
{

	struct intel_connector *connector = to_intel_connector(data);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int err;



	err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex);
@@ -1991,7 +1983,7 @@ static int i915_dp_force_link_retrain_write(void *data, u64 val) 
{

	struct intel_connector *connector = to_intel_connector(data);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int err;



	err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex);
@@ -2014,7 +2006,7 @@ static int i915_dp_link_retrain_disabled_show(struct seq_file *m, void *data) 
{

	struct intel_connector *connector = to_intel_connector(m->private);

	struct intel_display *display = to_intel_display(connector);

	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	int err;



	err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex);