Commit 41673c66 authored by Kunwu Chan's avatar Kunwu Chan Committed by Lee Jones
Browse files

mfd: syscon: Fix null pointer dereference in of_syscon_register() 



kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: e15d7f2b ("mfd: syscon: Use a unique name with regmap_config")
Signed-off-by: default avatarKunwu Chan <chentao@kylinos.cn>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20231204092443.2462115-1-chentao@kylinos.cn


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 0c679fff

drivers/mfd/syscon.c

+4 −0
Original line number Diff line number Diff line
@@ -105,6 +105,10 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_res) 
	}



	syscon_config.name = kasprintf(GFP_KERNEL, "%pOFn@%pa", np, &res.start);

	if (!syscon_config.name) {

		ret = -ENOMEM;

		goto err_regmap;

	}

	syscon_config.reg_stride = reg_io_width;

	syscon_config.val_bits = reg_io_width * 8;

	syscon_config.max_register = resource_size(&res) - reg_io_width;