Commit 417607de authored by Yuvraj Sakshith's avatar Yuvraj Sakshith Committed by Andrew Morton
Browse files

mm/page_reporting: add PAGE_REPORTING_ORDER_UNSPECIFIED 

Patch series "Allow order zero pages in page reporting", v4.

Today, page reporting sets page_reporting_order in two ways:

(1) page_reporting.page_reporting_order cmdline parameter
(2) Driver can pass order while registering itself.

In both cases, order zero is ignored by free page reporting because it is
used to set page_reporting_order to a default value, like MAX_PAGE_ORDER.

In some cases we might want page_reporting_order to be zero.

For instance, when virtio-balloon runs inside a guest with tiny memory
(say, 16MB), it might not be able to find a order 1 page (or in the worst
case order MAX_PAGE_ORDER page) after some uptime.  Page reporting should
be able to return order zero pages back for optimal memory relinquishment.

This patch changes the default fallback value from '0' to '-1' in all
possible clients of free page reporting (hv_balloon and virtio-balloon)
together with allowing '0' as a valid order in page_reporting_register().


This patch (of 5):

Drivers can pass order of pages to be reported while registering itself. 
Today, this is a magic number, 0.

Label this with PAGE_REPORTING_ORDER_UNSPECIFIED and check for it when the
driver is being registered.

This macro will be used in relevant drivers next.

[akpm@linux-foundation.org: tweak whitespace, per David]
Link: https://lkml.kernel.org/r/20260303113032.3008371-1-yuvraj.sakshith@oss.qualcomm.com
Link: https://lkml.kernel.org/r/20260303113032.3008371-2-yuvraj.sakshith@oss.qualcomm.com


Signed-off-by: default avatarYuvraj Sakshith <yuvraj.sakshith@oss.qualcomm.com>
Acked-by: default avatarDavid Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: default avatarMichael Kelley <mhklinux@outlook.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Cc: Brendan Jackman <jackmanb@google.com>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Eugenio Pérez <eperezma@redhat.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Long Li <longli@microsoft.com>
Cc: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 52af721b

include/linux/page_reporting.h

+1 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 


/* This value should always be a power of 2, see page_reporting_cycle() */

#define PAGE_REPORTING_CAPACITY		32

#define PAGE_REPORTING_ORDER_UNSPECIFIED	0



struct page_reporting_dev_info {

	/* function that alters pages to make them "reported" */

mm/page_reporting.c

+2 −1
Original line number Diff line number Diff line
@@ -370,7 +370,8 @@ int page_reporting_register(struct page_reporting_dev_info *prdev) 
	 */



	if (page_reporting_order == -1) {

		if (prdev->order > 0 && prdev->order <= MAX_PAGE_ORDER)

		if (prdev->order != PAGE_REPORTING_ORDER_UNSPECIFIED &&

		    prdev->order <= MAX_PAGE_ORDER)

			page_reporting_order = prdev->order;

		else

			page_reporting_order = pageblock_order;