Commit 417c3260 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

pinctrl: cy8c95x0: Don't use cy8c95x0_set_mode() twice 



Instead, call it once in cy8c95x0_pinmux_mode() and if selector is 0,
shortcut the flow by returning 0 immediately.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20221018151223.80846-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 1d66e379

drivers/pinctrl/pinctrl-cy8c95x0.c

+4 −4
Original line number Diff line number Diff line
@@ -1107,13 +1107,13 @@ static int cy8c95x0_pinmux_mode(struct cy8c95x0_pinctrl *chip, 
	u8 bit = cypress_get_pin_mask(chip, group);

	int ret;



	if (selector == 0)

		return cy8c95x0_set_mode(chip, group, false);



	ret = cy8c95x0_set_mode(chip, group, true);

	ret = cy8c95x0_set_mode(chip, group, selector);

	if (ret < 0)

		return ret;



	if (selector == 0)

		return 0;



	/* Set direction to output & set output to 1 so that PWM can work */

	ret = regmap_write_bits(chip->regmap, CY8C95X0_DIRECTION, bit, bit);

	if (ret < 0)