Commit 419a40cc authored by zhangheng's avatar zhangheng Committed by Krzysztof Kozlowski
Browse files

w1: core: use sysfs_emit() instead of sprintf() 



Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: default avatarzhangheng <zhangheng@kylinos.cn>
Link: https://lore.kernel.org/r/20241220102337.295864-1-zhangheng@kylinos.cn


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent 0f28374e

drivers/w1/slaves/w1_ds28e17.c

+2 −2
Original line number Diff line number Diff line
@@ -583,7 +583,7 @@ static ssize_t speed_show(struct device *dev, struct device_attribute *attr, 
		return result;



	/* Return current speed value. */

	return sprintf(buf, "%d\n", result);

	return sysfs_emit(buf, "%d\n", result);

}



static ssize_t speed_store(struct device *dev, struct device_attribute *attr,
@@ -633,7 +633,7 @@ static ssize_t stretch_show(struct device *dev, struct device_attribute *attr, 
	struct w1_f19_data *data = sl->family_data;



	/* Return current stretch value. */

	return sprintf(buf, "%d\n", data->stretch);

	return sysfs_emit(buf, "%d\n", data->stretch);

}



static ssize_t stretch_store(struct device *dev, struct device_attribute *attr,