Commit 41c13eaf authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Marc Kleine-Budde
Browse files

can: rcar_canfd: Invert reset assert order 



The two resets are asserted during cleanup in the same order as they
were deasserted during probe.  Invert the order to restore symmetry.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarVincent Mailhol <mailhol@kernel.org>
Reviewed-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Link: https://patch.msgid.link/20251124102837.106973-2-biju.das.jz@bp.renesas.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 113aa910

drivers/net/can/rcar/rcar_canfd.c

+2 −2
Original line number Diff line number Diff line
@@ -2192,8 +2192,8 @@ static int rcar_canfd_probe(struct platform_device *pdev) 
fail_clk:

	clk_disable_unprepare(gpriv->clkp);

fail_reset:

	reset_control_assert(gpriv->rstc1);

	reset_control_assert(gpriv->rstc2);

	reset_control_assert(gpriv->rstc1);

fail_dev:

	return err;

}
@@ -2214,8 +2214,8 @@ static void rcar_canfd_remove(struct platform_device *pdev) 
	/* Enter global sleep mode */

	rcar_canfd_set_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GSLPR);

	clk_disable_unprepare(gpriv->clkp);

	reset_control_assert(gpriv->rstc1);

	reset_control_assert(gpriv->rstc2);

	reset_control_assert(gpriv->rstc1);

}



static int __maybe_unused rcar_canfd_suspend(struct device *dev)