Unverified Commit 41d9a679 authored by Felix Gu's avatar Felix Gu Committed by Mark Brown
Browse files

spi: tegra: Fix a memory leak in tegra_slink_probe() 



In tegra_slink_probe(), when platform_get_irq() fails, it directly
returns from the function with an error code, which causes a memory leak.

Replace it with a goto label to ensure proper cleanup.

Fixes: eb9913b5 ("spi: tegra: Fix missing IRQ check in tegra_slink_probe()")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Reviewed-by: default avatarJon Hunter <jonathanh@nvidia.com>
Link: https://patch.msgid.link/20260202-slink-v1-1-eac50433a6f9@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent edf9088b

drivers/spi/spi-tegra20-slink.c

+4 −2
Original line number Diff line number Diff line
@@ -1086,8 +1086,10 @@ static int tegra_slink_probe(struct platform_device *pdev) 
	reset_control_deassert(tspi->rst);



	spi_irq = platform_get_irq(pdev, 0);

	if (spi_irq < 0)

		return spi_irq;

	if (spi_irq < 0) {

		ret = spi_irq;

		goto exit_pm_put;

	}

	tspi->irq = spi_irq;

	ret = request_threaded_irq(tspi->irq, tegra_slink_isr,

				   tegra_slink_isr_thread, IRQF_ONESHOT,