Commit 41dd6822 authored by Armin Wolf's avatar Armin Wolf Committed by Hans de Goede
Browse files

platform/x86: wmi: Remove unused variable in address space handler 



The variable "i" is always zero and only used in shift operations.
Remove it to make the code more readable.

Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20231218192420.305411-2-W_Armin@gmx.de


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent a92d3078

drivers/platform/x86/wmi.c

+3 −3
Original line number Diff line number Diff line
@@ -1144,7 +1144,7 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, 
			  u32 bits, u64 *value,

			  void *handler_context, void *region_context)

{

	int result = 0, i = 0;

	int result = 0;

	u8 temp = 0;



	if ((address > 0xFF) || !value)
@@ -1158,9 +1158,9 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, 


	if (function == ACPI_READ) {

		result = ec_read(address, &temp);

		(*value) |= ((u64)temp) << i;

		*value = temp;

	} else {

		temp = 0xff & ((*value) >> i);

		temp = 0xff & *value;

		result = ec_write(address, temp);

	}