Commit 41ee9023 authored by Lizhi Hou's avatar Lizhi Hou
Browse files

accel/amdxdna: Fix incorrect return value in aie2_hwctx_sync_debug_bo() 



When the driver issues the SYNC_DEBUG_BO command, it currently returns 0
even if the firmware fails to execute the command. Update the driver to
return -EINVAL in this case to properly indicate the failure.

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/dri-devel/aPsadTBXunUSBByV@stanley.mountain/


Fixes: 7ea04683 ("accel/amdxdna: Support firmware debug buffer")
Reviewed-by: default avatarMario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: default avatarLizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20251024162608.1544842-1-lizhi.hou@amd.com
parent b9e5e9d2

drivers/accel/amdxdna/aie2_ctx.c

+1 −1
Original line number Diff line number Diff line
@@ -879,7 +879,7 @@ int aie2_hwctx_sync_debug_bo(struct amdxdna_hwctx *hwctx, u32 debug_bo_hdl) 
	aie2_cmd_wait(hwctx, seq);

	if (cmd.result) {

		XDNA_ERR(xdna, "Response failure 0x%x", cmd.result);

		return ret;

		return -EINVAL;

	}



	return 0;