Commit 4200f873 authored by Iuliana Prodan's avatar Iuliana Prodan Committed by Mathieu Poirier
Browse files

remoteproc: imx_dsp_rproc: Wait for suspend ACK only if WAIT_FW_CONFIRMATION is set 



The DSP suspend path currently waits unconditionally for a suspend ack
from the firmware. This breaks firmwares that do not implement the
mailbox-based CONFIRMATION handshake, as the DSP never responds and
system suspend fails with -EBUSY.

The driver already uses the WAIT_FW_CONFIRMATION flag to indicate that
the firmware supports the CONFIRMATION handshake at boot. Apply the same
logic during suspend: only send the suspend message and wait for the
suspend ack when the firmware is expected to support it.

Signed-off-by: default avatarIuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarDaniel Baluta <daniel.baluta@nxp.com>
Link: https://lore.kernel.org/r/20251204122825.756106-3-iuliana.prodan@oss.nxp.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 424f22b4

drivers/remoteproc/imx_dsp_rproc.c

+6 −0
Original line number Diff line number Diff line
@@ -1251,6 +1251,12 @@ static int imx_dsp_suspend(struct device *dev) 
		goto out;

	}



	/* No fw confirmation expected, so trigger PM runtime suspend */

	if (!(priv->flags & WAIT_FW_CONFIRMATION)) {

		dev_dbg(dev, "No FW_CONFIRMATION needed, suspend directly.\n");

		goto out;

	}



	reinit_completion(&priv->pm_comp);



	/* Tell DSP that suspend is happening */