Commit 423df2e0 authored Feb 23, 2024 by Alex Elder Committed by Paolo Abeni Feb 27, 2024

net: ipa: kill ipa_power_suspend_handler()



Now that ipa_power_suspend_handler() is a trivial wrapper around
ipa_interrupt_suspend_clear_all(), we can open-code it in the one
place it's used, and get rid of the function.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

parent ef63ca78

drivers/net/ipa/ipa_interrupt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -44,7 +44,7 @@ struct ipa_interrupt {
		};

		/* Clear the suspend interrupt for all endpoints that signaled it */
		void ipa_interrupt_suspend_clear_all(struct ipa_interrupt *interrupt)
		static void ipa_interrupt_suspend_clear_all(struct ipa_interrupt *interrupt)
		{
		struct ipa *ipa = interrupt->ipa;
		u32 unit_count;
		@@ -94,7 +94,7 @@ static void ipa_interrupt_process(struct ipa_interrupt *interrupt, u32 irq_id)
		* caused the interrupt, so defer clearing until after
		* the handler has been called.
		*/
		ipa_power_suspend_handler(ipa, irq_id);
		ipa_interrupt_suspend_clear_all(interrupt);
		fallthrough;

		default: /* Silently ignore (and clear) any other condition */

drivers/net/ipa/ipa_interrupt.h

+0 −8

Original line number	Diff line number	Diff line
		@@ -34,14 +34,6 @@ void ipa_interrupt_suspend_enable(struct ipa_interrupt *interrupt,
		void ipa_interrupt_suspend_disable(struct ipa_interrupt *interrupt,
		u32 endpoint_id);

		/**
		* ipa_interrupt_suspend_clear_all - clear all suspend interrupts
		* @interrupt: IPA interrupt structure
		*
		* Clear the TX_SUSPEND interrupt for all endpoints that signaled it.
		*/
		void ipa_interrupt_suspend_clear_all(struct ipa_interrupt *interrupt);

		/**
		* ipa_interrupt_simulate_suspend() - Simulate TX_SUSPEND IPA interrupt
		* @interrupt: IPA interrupt structure

drivers/net/ipa/ipa_power.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -194,12 +194,6 @@ u32 ipa_core_clock_rate(struct ipa *ipa)
		return ipa->power ? (u32)clk_get_rate(ipa->power->core) : 0;
		}

		void ipa_power_suspend_handler(struct ipa *ipa, enum ipa_irq_id irq_id)
		{
		/* Acknowledge/clear the suspend interrupt on all endpoints */
		ipa_interrupt_suspend_clear_all(ipa->interrupt);
		}

		static int ipa_power_retention_init(struct ipa_power *power)
		{
		struct qmp *qmp = qmp_get(power->dev);

drivers/net/ipa/ipa_power.h

+0 −11

Original line number	Diff line number	Diff line
		@@ -30,17 +30,6 @@ u32 ipa_core_clock_rate(struct ipa *ipa);
		*/
		void ipa_power_retention(struct ipa *ipa, bool enable);

		/**
		* ipa_power_suspend_handler() - Handler for SUSPEND IPA interrupts
		* @ipa: IPA pointer
		* @irq_id: IPA interrupt ID (unused)
		*
		* If an RX endpoint is suspended, and the IPA has a packet destined for
		* that endpoint, the IPA generates a SUSPEND interrupt to inform the AP
		* that it should resume the endpoint.
		*/
		void ipa_power_suspend_handler(struct ipa *ipa, enum ipa_irq_id irq_id);

		/**
		* ipa_power_setup() - Set up IPA power management
		* @ipa: IPA pointer