Commit 42464c51 authored by Sasha Levin's avatar Sasha Levin Committed by Rob Clark
Browse files

drm/msm: Fix objtool warning in submit_lock_objects() 



Split the vmbind case into a separate helper function
submit_lock_objects_vmbind() to fix objtool warning:

  drivers/gpu/drm/msm/msm.o: warning: objtool: submit_lock_objects+0x451:
  sibling call from callable instruction with modified stack frame

The drm_exec_until_all_locked() macro uses computed gotos internally
for its retry loop. Having return statements inside this macro, or
immediately after it in certain code paths, confuses objtool's static
analysis of stack frames, causing it to incorrectly flag tail call
optimizations.

Fixes: 92395af6 ("drm/msm: Add VM_BIND submitqueue")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Patchwork: https://patchwork.freedesktop.org/patch/667539/


Signed-off-by: default avatarRob Clark <robin.clark@oss.qualcomm.com>
parent fe2f3b1c

drivers/gpu/drm/msm/msm_gem_submit.c

+27 −22
Original line number Diff line number Diff line
@@ -271,15 +271,11 @@ static int submit_lookup_cmds(struct msm_gem_submit *submit, 
	return ret;

}



/* This is where we make sure all the bo's are reserved and pin'd: */

static int submit_lock_objects(struct msm_gem_submit *submit)

static int submit_lock_objects_vmbind(struct msm_gem_submit *submit)

{

	unsigned flags = DRM_EXEC_INTERRUPTIBLE_WAIT;

	unsigned flags = DRM_EXEC_INTERRUPTIBLE_WAIT | DRM_EXEC_IGNORE_DUPLICATES;

	struct drm_exec *exec = &submit->exec;

	int ret;



	if (msm_context_is_vmbind(submit->queue->ctx)) {

		flags |= DRM_EXEC_IGNORE_DUPLICATES;

	int ret = 0;



	drm_exec_init(&submit->exec, flags, submit->nr_bos);
@@ -287,17 +283,26 @@ static int submit_lock_objects(struct msm_gem_submit *submit) 
		ret = drm_gpuvm_prepare_vm(submit->vm, exec, 1);

		drm_exec_retry_on_contention(exec);

		if (ret)

				return ret;

			break;



		ret = drm_gpuvm_prepare_objects(submit->vm, exec, 1);

		drm_exec_retry_on_contention(exec);

		if (ret)

				return ret;

			break;

	}



		return 0;

	return ret;

}



/* This is where we make sure all the bo's are reserved and pin'd: */

static int submit_lock_objects(struct msm_gem_submit *submit)

{

	unsigned flags = DRM_EXEC_INTERRUPTIBLE_WAIT;

	int ret = 0;



	if (msm_context_is_vmbind(submit->queue->ctx))

		return submit_lock_objects_vmbind(submit);



	drm_exec_init(&submit->exec, flags, submit->nr_bos);



	drm_exec_until_all_locked (&submit->exec) {
@@ -305,17 +310,17 @@ static int submit_lock_objects(struct msm_gem_submit *submit) 
					drm_gpuvm_resv_obj(submit->vm));

		drm_exec_retry_on_contention(&submit->exec);

		if (ret)

			return ret;

			break;

		for (unsigned i = 0; i < submit->nr_bos; i++) {

			struct drm_gem_object *obj = submit->bos[i].obj;

			ret = drm_exec_prepare_obj(&submit->exec, obj, 1);

			drm_exec_retry_on_contention(&submit->exec);

			if (ret)

				return ret;

				break;

		}

	}



	return 0;

	return ret;

}



static int submit_fence_sync(struct msm_gem_submit *submit)