Commit 4259964b authored by Wolfram Sang's avatar Wolfram Sang Committed by Andi Shyti
Browse files

i2c: synquacer: use 'time_left' variable with wait_for_completion_timeout() 



There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent 197264d3

drivers/i2c/busses/i2c-synquacer.c

+4 −4
Original line number Diff line number Diff line
@@ -311,7 +311,7 @@ static int synquacer_i2c_doxfer(struct synquacer_i2c *i2c, 
				struct i2c_msg *msgs, int num)

{

	unsigned char bsr;

	unsigned long timeout;

	unsigned long time_left;

	int ret;



	synquacer_i2c_hw_init(i2c);
@@ -335,9 +335,9 @@ static int synquacer_i2c_doxfer(struct synquacer_i2c *i2c, 
		return ret;

	}



	timeout = wait_for_completion_timeout(&i2c->completion,

	time_left = wait_for_completion_timeout(&i2c->completion,

						msecs_to_jiffies(i2c->timeout_ms));

	if (timeout == 0) {

	if (time_left == 0) {

		dev_dbg(i2c->dev, "timeout\n");

		return -EAGAIN;

	}