Commit 425c5f26 authored by Xuanqiang Luo's avatar Xuanqiang Luo Committed by Jakub Kicinski
Browse files

ice: Check VF VSI Pointer Value in ice_vc_add_fdir_fltr() 



As mentioned in the commit baeb705f ("ice: always check VF VSI
pointer values"), we need to perform a null pointer check on the return
value of ice_get_vf_vsi() before using it.

Fixes: 6ebbe97a ("ice: Add a per-VF limit on number of FDIR filters")
Signed-off-by: default avatarXuanqiang Luo <luoxuanqiang@kylinos.cn>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20250425222636.3188441-3-anthony.l.nguyen@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3ffcd7b6

drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c

+5 −0
Original line number Diff line number Diff line
@@ -2097,6 +2097,11 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg) 
	pf = vf->pf;

	dev = ice_pf_to_dev(pf);

	vf_vsi = ice_get_vf_vsi(vf);

	if (!vf_vsi) {

		dev_err(dev, "Can not get FDIR vf_vsi for VF %u\n", vf->vf_id);

		v_ret = VIRTCHNL_STATUS_ERR_PARAM;

		goto err_exit;

	}



#define ICE_VF_MAX_FDIR_FILTERS	128

	if (!ice_fdir_num_avail_fltr(&pf->hw, vf_vsi) ||