Commit 42602e3a authored by Jason Xing's avatar Jason Xing Committed by Martin KaFai Lau
Browse files

bpf: handle implicit declaration of function gettid in bpf_iter.c 



As we can see from the title, when I compiled the selftests/bpf, I
saw the error:
implicit declaration of function ‘gettid’ ; did you mean ‘getgid’? [-Werror=implicit-function-declaration]
  skel->bss->tid = gettid();
                   ^~~~~~
                   getgid

Directly call the syscall solves this issue.

Signed-off-by: default avatarJason Xing <kernelxing@tencent.com>
Reviewed-by: default avatarAlan Maguire <alan.maguire@oracle.com>
Tested-by: default avatarAlan Maguire <alan.maguire@oracle.com>
Link: https://lore.kernel.org/r/20241029074627.80289-1-kerneljasonxing@gmail.com


Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
parent 87cb58ae

tools/testing/selftests/bpf/prog_tests/bpf_iter.c

+3 −3
Original line number Diff line number Diff line
@@ -226,7 +226,7 @@ static void test_task_common_nocheck(struct bpf_iter_attach_opts *opts, 
	ASSERT_OK(pthread_create(&thread_id, NULL, &do_nothing_wait, NULL),

		  "pthread_create");



	skel->bss->tid = gettid();

	skel->bss->tid = syscall(SYS_gettid);



	do_dummy_read_opts(skel->progs.dump_task, opts);
@@ -255,10 +255,10 @@ static void *run_test_task_tid(void *arg) 
	union bpf_iter_link_info linfo;

	int num_unknown_tid, num_known_tid;



	ASSERT_NEQ(getpid(), gettid(), "check_new_thread_id");

	ASSERT_NEQ(getpid(), syscall(SYS_gettid), "check_new_thread_id");



	memset(&linfo, 0, sizeof(linfo));

	linfo.task.tid = gettid();

	linfo.task.tid = syscall(SYS_gettid);

	opts.link_info = &linfo;

	opts.link_info_len = sizeof(linfo);

	test_task_common(&opts, 0, 1);