Commit 427c70de authored by Mario Limonciello's avatar Mario Limonciello Committed by Hans de Goede
Browse files

platform/x86: thinkpad_acpi: Only update profile if successfully converted 



Randomly a Lenovo Z13 will trigger a kernel warning traceback from this
condition:

```
if (WARN_ON((profile < 0) || (profile >= ARRAY_SIZE(profile_names))))
```

This happens because thinkpad-acpi always assumes that
convert_dytc_to_profile() successfully updated the profile. On the
contrary a condition can occur that when dytc_profile_refresh() is called
the profile doesn't get updated as there is a -EOPNOTSUPP branch.

Catch this situation and avoid updating the profile. Also log this into
dynamic debugging in case any other modes should be added in the future.

Fixes: c3bfcd4c ("platform/x86: thinkpad_acpi: Add platform profile support")
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20240217022311.113879-1-mario.limonciello@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 84c16d01

drivers/platform/x86/thinkpad_acpi.c

+3 −2
Original line number Diff line number Diff line
@@ -10308,6 +10308,7 @@ static int convert_dytc_to_profile(int funcmode, int dytcmode, 
		return 0;

	default:

		/* Unknown function */

		pr_debug("unknown function 0x%x\n", funcmode);

		return -EOPNOTSUPP;

	}

	return 0;
@@ -10493,8 +10494,8 @@ static void dytc_profile_refresh(void) 
		return;



	perfmode = (output >> DYTC_GET_MODE_BIT) & 0xF;

	convert_dytc_to_profile(funcmode, perfmode, &profile);

	if (profile != dytc_current_profile) {

	err = convert_dytc_to_profile(funcmode, perfmode, &profile);

	if (!err && profile != dytc_current_profile) {

		dytc_current_profile = profile;

		platform_profile_notify();

	}