Commit 42ea9cf2 authored by Donet Tom's avatar Donet Tom Committed by Alex Deucher
Browse files

drm/amdkfd: Relax size checking during queue buffer get 



HW-supported EOP buffer sizes are 4K and 32K. On systems that do not
use 4K pages, the minimum buffer object (BO) allocation size is
PAGE_SIZE (for example, 64K). During queue buffer acquisition, the driver
currently checks the allocated BO size against the supported EOP buffer
size. Since the allocated BO is larger than the expected size, this check
fails, preventing queue creation.

Relax the strict size validation and allow PAGE_SIZE-sized BOs to be used.
Only the required 4K region of the buffer will be used as the EOP buffer
and avoids queue creation failures on non-4K page systems.

Acked-by: default avatarChristian König <christian.koenig@amd.com>
Suggested-by: default avatarPhilip Yang <yangp@amd.com>
Signed-off-by: default avatarDonet Tom <donettom@linux.ibm.com>
Signed-off-by: default avatarFelix Kuehling <felix.kuehling@amd.com>
Reviewed-by: default avatarFelix Kuehling <felix.kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 318b1c36

drivers/gpu/drm/amd/amdkfd/kfd_queue.c

+3 −3
Original line number Diff line number Diff line
@@ -278,8 +278,8 @@ int kfd_queue_acquire_buffers(struct kfd_process_device *pdd, struct queue_prope 


	/* EOP buffer is not required for all ASICs */

	if (properties->eop_ring_buffer_address) {

		if (properties->eop_ring_buffer_size != topo_dev->node_props.eop_buffer_size) {

			pr_debug("queue eop bo size 0x%x not equal to node eop buf size 0x%x\n",

		if (properties->eop_ring_buffer_size < topo_dev->node_props.eop_buffer_size) {

			pr_debug("queue eop bo size 0x%x is less than node eop buf size 0x%x\n",

				properties->eop_ring_buffer_size,

				topo_dev->node_props.eop_buffer_size);

			err = -EINVAL;
@@ -287,7 +287,7 @@ int kfd_queue_acquire_buffers(struct kfd_process_device *pdd, struct queue_prope 
		}

		err = kfd_queue_buffer_get(vm, (void *)properties->eop_ring_buffer_address,

					   &properties->eop_buf_bo,

					   properties->eop_ring_buffer_size);

					   ALIGN(properties->eop_ring_buffer_size, PAGE_SIZE));

		if (err)

			goto out_err_unreserve;

	}