Commit 434fffa9 authored by James Clark's avatar James Clark Committed by Namhyung Kim
Browse files

perf probe: Fix uninitialized variable 



Since the linked fixes: commit, err is returned uninitialized due to the
removal of "return 0". Initialize err to fix it.

This fixes the following intermittent test failure on release builds:

 $ perf test "testsuite_probe"
 ...
 -- [ FAIL ] -- perf_probe :: test_invalid_options :: mutually exclusive options :: -L foo -V bar (output regexp parsing)
 Regexp not found: \"Error: switch .+ cannot be used with switch .+\"
 ...

Fixes: 080e47b2 ("perf probe: Introduce quotation marks support")
Tested-by: default avatarNamhyung Kim <namhyung@kernel.org>
Reviewed-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: default avatarJames Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20241211085525.519458-2-james.clark@linaro.org


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent f7e36d02

tools/perf/util/probe-event.c

+1 −1
Original line number Diff line number Diff line
@@ -1370,7 +1370,7 @@ int parse_line_range_desc(const char *arg, struct line_range *lr) 
{

	char *buf = strdup(arg);

	char *p;

	int err;

	int err = 0;



	if (!buf)

		return -ENOMEM;