Unverified Commit 4363f02a authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: Intel: sof_sdw: Fix unlikely uninitialized variable use in create_sdw_dailinks() 



Initialize current_be_id to 0 to handle the unlikely case when there are
no devices connected to a DAI.
In this case create_sdw_dailink() would return without touching the passed
pointer to current_be_id.

Found by gcc -fanalyzer

Fixes: 59bf457d ("ASoC: intel: sof_sdw: Factor out SoundWire DAI creation")
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20250303065552.78328-1-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7eb17214

sound/soc/intel/boards/sof_sdw.c

+1 −1
Original line number Diff line number Diff line
@@ -954,7 +954,7 @@ static int create_sdw_dailinks(struct snd_soc_card *card, 


	/* generate DAI links by each sdw link */

	while (sof_dais->initialised) {

		int current_be_id;

		int current_be_id = 0;



		ret = create_sdw_dailink(card, sof_dais, dai_links,

					 &current_be_id, codec_conf);