Commit 437889b9 authored by Artem Sadovnikov's avatar Artem Sadovnikov Committed by Steven Rostedt (Google)
Browse files

fgraph: Make pid_str size match the comment 

The comment above buffer mentions sign, 10 bytes width for number and null
terminator, but buffer itself isn't large enough to hold that much data.

This is a cosmetic change, since PID cannot be negative, other than -1.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Link: https://lore.kernel.org/20250617152110.2530-1-a.sadovnikov@ispras.ru


Signed-off-by: default avatarArtem Sadovnikov <a.sadovnikov@ispras.ru>
Reviewed-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent d7b8f8e2

kernel/trace/trace_functions_graph.c

+1 −1
Original line number Diff line number Diff line
@@ -513,7 +513,7 @@ static void print_graph_proc(struct trace_seq *s, pid_t pid) 
{

	char comm[TASK_COMM_LEN];

	/* sign + log10(MAX_INT) + '\0' */

	char pid_str[11];

	char pid_str[12];

	int spaces = 0;

	int len;

	int i;