Commit 437cc605 authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by David Sterba
Browse files

btrfs: remove zoned statistics from sysfs 



Remove the newly introduced zoned statistics from sysfs, as sysfs can
only show a single page this will truncate the output on a busy
filesystem.

Reviewed-by: default avatarFilipe Manana <fdmanana@suse.com>
Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent a11224a0

fs/btrfs/sysfs.c

+0 −52
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ 
#include "misc.h"

#include "fs.h"

#include "accessors.h"

#include "zoned.h"



/*

 * Structure name                       Path
@@ -1189,56 +1188,6 @@ static ssize_t btrfs_commit_stats_store(struct kobject *kobj, 
}

BTRFS_ATTR_RW(, commit_stats, btrfs_commit_stats_show, btrfs_commit_stats_store);



static ssize_t btrfs_zoned_stats_show(struct kobject *kobj,

				      struct kobj_attribute *a, char *buf)

{

	struct btrfs_fs_info *fs_info = to_fs_info(kobj);

	struct btrfs_block_group *bg;

	size_t ret = 0;





	if (!btrfs_is_zoned(fs_info))

		return ret;



	spin_lock(&fs_info->zone_active_bgs_lock);

	ret += sysfs_emit_at(buf, ret, "active block-groups: %zu\n",

			     list_count_nodes(&fs_info->zone_active_bgs));

	spin_unlock(&fs_info->zone_active_bgs_lock);



	mutex_lock(&fs_info->reclaim_bgs_lock);

	spin_lock(&fs_info->unused_bgs_lock);

	ret += sysfs_emit_at(buf, ret, "\treclaimable: %zu\n",

			     list_count_nodes(&fs_info->reclaim_bgs));

	ret += sysfs_emit_at(buf, ret, "\tunused: %zu\n",

			     list_count_nodes(&fs_info->unused_bgs));

	spin_unlock(&fs_info->unused_bgs_lock);

	mutex_unlock(&fs_info->reclaim_bgs_lock);



	ret += sysfs_emit_at(buf, ret, "\tneed reclaim: %s\n",

			     str_true_false(btrfs_zoned_should_reclaim(fs_info)));



	if (fs_info->data_reloc_bg)

		ret += sysfs_emit_at(buf, ret,

				     "data relocation block-group: %llu\n",

				     fs_info->data_reloc_bg);

	if (fs_info->treelog_bg)

		ret += sysfs_emit_at(buf, ret,

				     "tree-log block-group: %llu\n",

				     fs_info->treelog_bg);



	spin_lock(&fs_info->zone_active_bgs_lock);

	ret += sysfs_emit_at(buf, ret, "active zones:\n");

	list_for_each_entry(bg, &fs_info->zone_active_bgs, active_bg_list) {

		ret += sysfs_emit_at(buf, ret,

				     "\tstart: %llu, wp: %llu used: %llu, reserved: %llu, unusable: %llu\n",

				     bg->start, bg->alloc_offset, bg->used,

				     bg->reserved, bg->zone_unusable);

	}

	spin_unlock(&fs_info->zone_active_bgs_lock);

	return ret;

}

BTRFS_ATTR(, zoned_stats, btrfs_zoned_stats_show);



static ssize_t btrfs_clone_alignment_show(struct kobject *kobj,

				struct kobj_attribute *a, char *buf)

{
@@ -1651,7 +1600,6 @@ static const struct attribute *btrfs_attrs[] = { 
	BTRFS_ATTR_PTR(, bg_reclaim_threshold),

	BTRFS_ATTR_PTR(, commit_stats),

	BTRFS_ATTR_PTR(, temp_fsid),

	BTRFS_ATTR_PTR(, zoned_stats),

#ifdef CONFIG_BTRFS_EXPERIMENTAL

	BTRFS_ATTR_PTR(, offload_csum),

#endif