Commit 438a35e7 authored by Kemeng Shi's avatar Kemeng Shi Committed by Theodore Ts'o
Browse files

ext4: remove unused parameter ngroup in ext4_mb_choose_next_group_*() 



Remove unused parameter ngroup in ext4_mb_choose_next_group_*().

Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarOjaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://lore.kernel.org/r/20240105092102.496631-3-shikemeng@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 133de5a0

fs/ext4/mballoc.c

+6 −6
Original line number Diff line number Diff line
@@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp) 
 * cr level needs an update.

 */

static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac,

			enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)

			enum criteria *new_cr, ext4_group_t *group)

{

	struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);

	struct ext4_group_info *iter;
@@ -944,7 +944,7 @@ ext4_mb_find_good_group_avg_frag_lists(struct ext4_allocation_context *ac, int o 
 * order. Updates *new_cr if cr level needs an update.

 */

static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *ac,

		enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)

		enum criteria *new_cr, ext4_group_t *group)

{

	struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);

	struct ext4_group_info *grp = NULL;
@@ -989,7 +989,7 @@ static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context * 
 * much and fall to CR_GOAL_LEN_SLOW in that case.

 */

static void ext4_mb_choose_next_group_best_avail(struct ext4_allocation_context *ac,

		enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)

		enum criteria *new_cr, ext4_group_t *group)

{

	struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);

	struct ext4_group_info *grp = NULL;
@@ -1124,11 +1124,11 @@ static void ext4_mb_choose_next_group(struct ext4_allocation_context *ac, 
	}



	if (*new_cr == CR_POWER2_ALIGNED) {

		ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group, ngroups);

		ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group);

	} else if (*new_cr == CR_GOAL_LEN_FAST) {

		ext4_mb_choose_next_group_goal_fast(ac, new_cr, group, ngroups);

		ext4_mb_choose_next_group_goal_fast(ac, new_cr, group);

	} else if (*new_cr == CR_BEST_AVAIL_LEN) {

		ext4_mb_choose_next_group_best_avail(ac, new_cr, group, ngroups);

		ext4_mb_choose_next_group_best_avail(ac, new_cr, group);

	} else {

		/*

		 * TODO: For CR=2, we can arrange groups in an rb tree sorted by