Commit 43c0f645 authored by Salah Triki's avatar Salah Triki Committed by Jonathan Cameron
Browse files

iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe() 



`devm_gpiod_get_optional()` may return non-NULL error pointer on failure.
Check its return value using `IS_ERR()` and propagate the error if
necessary.

Fixes: df6e7125 ("iio: pressure: bmp280: Explicitly mark GPIO optional")
Signed-off-by: default avatarSalah Triki <salah.triki@gmail.com>
Reviewed-by: default avatarDavid Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250818092740.545379-2-salah.triki@gmail.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 433b99e9

drivers/iio/pressure/bmp280-core.c

+5 −4
Original line number Diff line number Diff line
@@ -3213,11 +3213,12 @@ int bmp280_common_probe(struct device *dev, 


	/* Bring chip out of reset if there is an assigned GPIO line */

	gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);

	if (IS_ERR(gpiod))

		return dev_err_probe(dev, PTR_ERR(gpiod), "failed to get reset GPIO\n");



	/* Deassert the signal */

	if (gpiod) {

	dev_info(dev, "release reset\n");

	gpiod_set_value(gpiod, 0);

	}



	data->regmap = regmap;