Commit 43d0035b authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'unmask-dscp-bits' 

Ido Schimmel says:

====================
Unmask upper DSCP bits - part 2

tl;dr - This patchset continues to unmask the upper DSCP bits in the
IPv4 flow key in preparation for allowing IPv4 FIB rules to match on
DSCP. No functional changes are expected. Part 1 was merged in commit
("Merge branch 'unmask-upper-dscp-bits-part-1'").

The TOS field in the IPv4 flow key ('flowi4_tos') is used during FIB
lookup to match against the TOS selector in FIB rules and routes.

It is currently impossible for user space to configure FIB rules that
match on the DSCP value as the upper DSCP bits are either masked in the
various call sites that initialize the IPv4 flow key or along the path
to the FIB core.

In preparation for adding a DSCP selector to IPv4 and IPv6 FIB rules, we
need to make sure the entire DSCP value is present in the IPv4 flow key.
This patchset continues to unmask the upper DSCP bits, but this time in
the output route path.

Patches #1-#3 unmask the upper DSCP bits in the various places that
invoke the core output route lookup functions directly.

Patches #4-#6 do the same in three helpers that are widely used in the
output path to initialize the TOS field in the IPv4 flow key.

The rest of the patches continue to unmask these bits in call sites that
invoke the following wrappers around the core lookup functions:

Patch #7 - __ip_route_output_key()
Patches #8-#12 - ip_route_output_flow()

The next patchset will handle the callers of ip_route_output_ports() and
ip_route_output_key().

No functional changes are expected as commit 1fa3314c ("ipv4:
Centralize TOS matching") moved the masking of the upper DSCP bits to
the core where 'flowi4_tos' is matched against the TOS selector.

Changes since v1 [1]:

* Remove IPTOS_RT_MASK in patch #7 instead of in patch #6

[1] https://lore.kernel.org/netdev/20240827111813.2115285-1-idosch@nvidia.com/


====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents cff69f72 50033400

drivers/net/ipvlan/ipvlan_core.c

+3 −1
Original line number Diff line number Diff line
@@ -2,6 +2,8 @@ 
/* Copyright (c) 2014 Mahesh Bandewar <maheshb@google.com>

 */



#include <net/inet_dscp.h>



#include "ipvlan.h"



static u32 ipvlan_jhash_secret __read_mostly;
@@ -420,7 +422,7 @@ static noinline_for_stack int ipvlan_process_v4_outbound(struct sk_buff *skb) 
	int err, ret = NET_XMIT_DROP;

	struct flowi4 fl4 = {

		.flowi4_oif = dev->ifindex,

		.flowi4_tos = RT_TOS(ip4h->tos),

		.flowi4_tos = ip4h->tos & INET_DSCP_MASK,

		.flowi4_flags = FLOWI_FLAG_ANYSRC,

		.flowi4_mark = skb->mark,

		.daddr = ip4h->daddr,

drivers/net/vrf.c

+2 −1
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ 
#include <net/sch_generic.h>

#include <net/netns/generic.h>

#include <net/netfilter/nf_conntrack.h>

#include <net/inet_dscp.h>



#define DRV_NAME	"vrf"

#define DRV_VERSION	"1.1"
@@ -520,7 +521,7 @@ static netdev_tx_t vrf_process_v4_outbound(struct sk_buff *skb, 
	/* needed to match OIF rule */

	fl4.flowi4_l3mdev = vrf_dev->ifindex;

	fl4.flowi4_iif = LOOPBACK_IFINDEX;

	fl4.flowi4_tos = RT_TOS(ip4h->tos);

	fl4.flowi4_tos = ip4h->tos & INET_DSCP_MASK;

	fl4.flowi4_flags = FLOWI_FLAG_ANYSRC;

	fl4.flowi4_proto = ip4h->protocol;

	fl4.daddr = ip4h->daddr;

include/net/ip.h

+4 −1
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ 
#include <net/flow_dissector.h>

#include <net/netns/hash.h>

#include <net/lwtunnel.h>

#include <net/inet_dscp.h>



#define IPV4_MAX_PMTU		65535U		/* RFC 2675, Section 5.1 */

#define IPV4_MIN_MTU		68			/* RFC 791 */
@@ -258,7 +259,9 @@ static inline u8 ip_sendmsg_scope(const struct inet_sock *inet, 


static inline __u8 get_rttos(struct ipcm_cookie* ipc, struct inet_sock *inet)

{

	return (ipc->tos != -1) ? RT_TOS(ipc->tos) : RT_TOS(READ_ONCE(inet->tos));

	u8 dsfield = ipc->tos != -1 ? ipc->tos : READ_ONCE(inet->tos);



	return dsfield & INET_DSCP_MASK;

}



/* datagram.c */

include/net/route.h

+2 −3
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
#include <net/ip_fib.h>

#include <net/arp.h>

#include <net/ndisc.h>

#include <net/inet_dscp.h>

#include <linux/in_route.h>

#include <linux/rtnetlink.h>

#include <linux/rcupdate.h>
@@ -45,7 +46,7 @@ static inline __u8 ip_sock_rt_scope(const struct sock *sk) 


static inline __u8 ip_sock_rt_tos(const struct sock *sk)

{

	return RT_TOS(READ_ONCE(inet_sk(sk)->tos));

	return READ_ONCE(inet_sk(sk)->tos) & INET_DSCP_MASK;

}



struct ip_tunnel_info;
@@ -265,8 +266,6 @@ static inline void ip_rt_put(struct rtable *rt) 
	dst_release(&rt->dst);

}



#define IPTOS_RT_MASK	(IPTOS_TOS_MASK & ~3)



extern const __u8 ip_tos2prio[16];



static inline char rt_tos2priority(u8 tos)

net/core/filter.c

+1 −1
Original line number Diff line number Diff line
@@ -2372,7 +2372,7 @@ static int __bpf_redirect_neigh_v4(struct sk_buff *skb, struct net_device *dev, 
		struct flowi4 fl4 = {

			.flowi4_flags = FLOWI_FLAG_ANYSRC,

			.flowi4_mark  = skb->mark,

			.flowi4_tos   = RT_TOS(ip4h->tos),

			.flowi4_tos   = ip4h->tos & INET_DSCP_MASK,

			.flowi4_oif   = dev->ifindex,

			.flowi4_proto = ip4h->protocol,

			.daddr	      = ip4h->daddr,