Commit 43dfc13c authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'pci-v6.19-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci 

Pull PCI updates from Bjorn Helgaas:
 "Enumeration:

   - Enable host bridge emulation for PCI_DOMAINS_GENERIC platforms (Dan
     Williams)

   - Switch vmd from custom domain number allocator to the common
     allocator to prevent a potential race with new non-VMD buses (Dan
     Williams)

   - Enable Precision Time Measurement (PTM) only if device advertises
     support for a relevant role, to prevent invalid PTM Requests that
     cause ACS violations that are reported as AER Uncorrectable
     Non-Fatal errors (Mika Westerberg)

  Resource management:

   - Prevent resource tree corruption when BAR resize fails (Ilpo
     Järvinen)

   - Restore BARs to the original size if a BAR resize fails (Ilpo
     Järvinen)

   - Remove BAR release from BAR resize attempts by the xe, i915, and
     amdgpu drivers so the PCI core can restore BARs if the resize fails
     (Ilpo Järvinen)

   - Move Resizable BAR code to rebar.c (Ilpo Järvinen)

   - Add pci_rebar_size_supported() and use it in i915 and xe (Ilpo
     Järvinen)

   - Add pci_rebar_get_max_size() and use it in xe and amdgpu (Ilpo
     Järvinen)

  Power management and error handling:

   - For drivers using PCI legacy suspend, save config state at suspend
     so that state (not any earlier state from enumeration, probe, or
     error recovery) will be restored when resuming (Lukas Wunner)

   - For devices with no driver or a driver that lacks power management,
     save config state at hibernate so that state (not any earlier state
     from enumeration, probe, or error recovery) will be restored when
     resuming (Lukas Wunner)

   - Save device config space on device addition, before driver binding,
     so error recovery works more reliably (Lukas Wunner)

   - Drop pci_save_state() from several drivers that no longer need it
     since the PCI core always does it and pci_restore_state() no longer
     invalidates the saved state (Lukas Wunner)

   - Document use of pci_save_state() by drivers to capture the state
     they want restored during error recovery (Lukas Wunner)

  Power control:

   - Add a struct pci_ops.assert_perst() function pointer to
     assert/deassert PCIe PERST# and implement it for the qcom driver
     (Krishna Chaitanya Chundru)

   - Add DT binding and pwrctrl driver for the Toshiba TC9563 PCIe
     switch, which must be held in reset after poweron so the pwrctrl
     driver can configure the switch via I2C before bringing up the
     links (Krishna Chaitanya Chundru)

  Endpoint framework:

   - Convert the endpoint doorbell test to use a threaded IRQ to fix a
     'sleeping while atomic' issue (Bhanu Seshu Kumar Valluri)

   - Add endpoint VNTB MSI doorbell support to reduce latency between
     host and endpoint (Frank Li)

  New native PCIe controller drivers:

   - Add CIX Sky1 host controller DT binding and driver (Hans Zhang)

   - Add NXP S32G host controller DT binding and driver (Vincent
     Guittot)

   - Add Renesas RZ/G3S host controller DT binding and driver (Claudiu
     Beznea)

   - Add SpacemiT K1 host controller DT binding and driver (Alex Elder)

  Amlogic Meson PCIe controller driver:

   - Update DT binding to name DBI region 'dbi', not 'elbi', and update
     driver to support both (Manivannan Sadhasivam)

  Apple PCIe controller driver:

   - Move struct pci_host_bridge allocation from pci_host_common_init()
     to callers, which significantly simplifies pcie-apple (Marc
     Zyngier)

  Broadcom STB PCIe controller driver:

   - Disable advertising ASPM L0s support correctly (Jim Quinlan)

   - Add a panic/die handler to print diagnostic info in case PCIe
     caused an unrecoverable abort (Jim Quinlan)

  Cadence PCIe controller driver:

   - Add module support for Cadence platform host and endpoint
     controller driver (Manikandan K Pillai)

   - Split headers into 'legacy' (LGA) and 'high perf' (HPA) to prepare
     for new CIX Sky1 driver (Manikandan K Pillai)

  MediaTek PCIe controller driver:

   - Convert DT binding to YAML schema (Christian Marangi)

   - Add Airoha AN7583 DT compatible and driver support (Christian
     Marangi)

  Qualcomm PCIe controller driver:

   - Add Qualcomm Kaanapali to SM8550 DT binding (Qiang Yu)

   - Add required 'power-domains' and 'resets' to qcom sa8775p, sc7280,
     sc8280xp, sm8150, sm8250, sm8350, sm8450, sm8550, x1e80100 DT
     schemas (Krzysztof Kozlowski)

   - Look up OPP using both frequency and data rate (not just frequency)
     so RPMh votes can account for both (Krishna Chaitanya Chundru)

  Rockchip DesignWare PCIe controller driver:

   - Add Rockchip RK3528 compatible strings in DT binding (Yao Zi)

  STMicroelectronics STM32MP25 PCIe controller driver:

   - Fix a race between link training and endpoint register
     initialization (Christian Bruel)

   - Align endpoint allocations to match the ATU requirements (Christian
     Bruel)

  Synopsys DesignWare PCIe controller driver:

   - Clear L1 PM Substate Capability 'Supported' bits unless glue driver
     says it's supported, which prevents users from enabling non-working
     L1SS. Currently only qcom and tegra194 support L1SS (Bjorn Helgaas)

   - Remove now-superfluous L1SS disable code from tegra194 (Bjorn
     Helgaas)

   - Configure L1SS support in dw-rockchip when DT says
     'supports-clkreq' (Shawn Lin)

  TI Keystone PCIe controller driver:

   - Fail the probe instead of silently succeeding if ks_pcie_of_data
     didn't specify Root Complex or Endpoint mode (Siddharth Vadapalli)

   - Make keystone buildable as a loadable module, except on ARM32 where
     hook_fault_code() is __init (Siddharth Vadapalli)"

* tag 'pci-v6.19-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci: (100 commits)
  MAINTAINERS: Add Manivannan Sadhasivam as PCI/pwrctrl maintainer
  MAINTAINERS: Add CIX Sky1 PCIe controller driver maintainer
  PCI: sky1: Add PCIe host support for CIX Sky1
  dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex bindings
  PCI: cadence: Add support for High Perf Architecture (HPA) controller
  MAINTAINERS: Add NXP S32G PCIe controller driver maintainer
  PCI: s32g: Add NXP S32G PCIe controller driver (RC)
  PCI: dwc: Add register and bitfield definitions
  dt-bindings: PCI: s32g: Add NXP S32G PCIe controller
  PCI: Add Renesas RZ/G3S host controller driver
  PCI: host-generic: Move bridge allocation outside of pci_host_common_init()
  dt-bindings: PCI: Add Renesas RZ/G3S PCIe controller binding
  PCI: Validate pci_rebar_size_supported() input
  Documentation: PCI: Amend error recovery doc with pci_save_state() rules
  treewide: Drop pci_save_state() after pci_restore_state()
  PCI/ERR: Ensure error recoverability at all times
  PCI/PM: Stop needlessly clearing state_saved on enumeration and thaw
  PCI/PM: Reinstate clearing state_saved in legacy and !PM codepaths
  PCI: dw-rockchip: Configure L1SS support
  PCI: tegra194: Remove unnecessary L1SS disable code
  ...
parents b1dd1e2f cd6b7c82

Documentation/PCI/pci-error-recovery.rst

+15 −0
Original line number Diff line number Diff line
@@ -326,6 +326,21 @@ be recovered, there is nothing more that can be done; the platform 
will typically report a "permanent failure" in such a case.  The

device will be considered "dead" in this case.



Drivers typically need to call pci_restore_state() after reset to

re-initialize the device's config space registers and thereby

bring it from D0\ :sub:`uninitialized` into D0\ :sub:`active` state

(PCIe r7.0 sec 5.3.1.1).  The PCI core invokes pci_save_state()

on enumeration after initializing config space to ensure that a

saved state is available for subsequent error recovery.

Drivers which modify config space on probe may need to invoke

pci_save_state() afterwards to record those changes for later

error recovery.  When going into system suspend, pci_save_state()

is called for every PCI device and that state will be restored

not only on resume, but also on any subsequent error recovery.

In the unlikely event that the saved state recorded on suspend

is unsuitable for error recovery, drivers should call

pci_save_state() on resume.



Drivers for multi-function cards will need to coordinate among

themselves as to which driver instance will perform any "one-shot"

or global device initialization. For example, the Symbios sym53cxx2

Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml

+12 −11
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ allOf: 
select:

  properties:

    compatible:

      contains:

        enum:

          - amlogic,axg-pcie

          - amlogic,g12a-pcie
@@ -36,13 +37,13 @@ properties: 


  reg:

    items:

      - description: External local bus interface registers

      - description: Data Bus Interface registers

      - description: Meson designed configuration registers

      - description: PCIe configuration space



  reg-names:

    items:

      - const: elbi

      - const: dbi

      - const: cfg

      - const: config
@@ -51,15 +52,15 @@ properties: 


  clocks:

    items:

      - description: PCIe PHY clock

      - description: PCIe GEN 100M PLL clock

      - description: PCIe RC clock gate

      - description: PCIe PHY clock



  clock-names:

    items:

      - const: general

      - const: pclk

      - const: port

      - const: general



  phys:

    maxItems: 1
@@ -88,7 +89,7 @@ required: 
  - reg

  - reg-names

  - interrupts

  - clock

  - clocks

  - clock-names

  - "#address-cells"

  - "#size-cells"
@@ -113,10 +114,10 @@ examples: 
    pcie: pcie@f9800000 {

        compatible = "amlogic,axg-pcie", "snps,dw-pcie";

        reg = <0xf9800000 0x400000>, <0xff646000 0x2000>, <0xf9f00000 0x100000>;

        reg-names = "elbi", "cfg", "config";

        reg-names = "dbi", "cfg", "config";

        interrupts = <GIC_SPI 177 IRQ_TYPE_EDGE_RISING>;

        clocks = <&pclk>, <&clk_port>, <&clk_phy>;

        clock-names = "pclk", "port", "general";

        clocks = <&clk_phy>, <&pclk>, <&clk_port>;

        clock-names = "general", "pclk", "port";

        resets = <&reset_pcie_port>, <&reset_pcie_apb>;

        reset-names = "port", "apb";

        phys = <&pcie_phy>;

Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml

0 → 100644
+83 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

%YAML 1.2

---

$id: http://devicetree.org/schemas/pci/cix,sky1-pcie-host.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: CIX Sky1 PCIe Root Complex



maintainers:

  - Hans Zhang <hans.zhang@cixtech.com>



description:

  PCIe root complex controller based on the Cadence PCIe core.



allOf:

  - $ref: /schemas/pci/pci-host-bridge.yaml#



properties:

  compatible:

    const: cix,sky1-pcie-host



  reg:

    items:

      - description: PCIe controller registers.

      - description: ECAM registers.

      - description: Remote CIX System Unit strap registers.

      - description: Remote CIX System Unit status registers.

      - description: Region for sending messages registers.



  reg-names:

    items:

      - const: reg

      - const: cfg

      - const: rcsu_strap

      - const: rcsu_status

      - const: msg



  ranges:

    maxItems: 3



required:

  - compatible

  - ranges

  - bus-range

  - device_type

  - interrupt-map

  - interrupt-map-mask

  - msi-map



unevaluatedProperties: false



examples:

  - |

    #include <dt-bindings/interrupt-controller/arm-gic.h>



    soc {

        #address-cells = <2>;

        #size-cells = <2>;



        pcie@a010000 {

            compatible = "cix,sky1-pcie-host";

            reg = <0x00 0x0a010000 0x00 0x10000>,

                  <0x00 0x2c000000 0x00 0x4000000>,

                  <0x00 0x0a000300 0x00 0x100>,

                  <0x00 0x0a000400 0x00 0x100>,

                  <0x00 0x60000000 0x00 0x00100000>;

            reg-names = "reg", "cfg", "rcsu_strap", "rcsu_status", "msg";

            ranges = <0x01000000 0x00 0x60100000 0x00 0x60100000 0x00 0x00100000>,

                     <0x02000000 0x00 0x60200000 0x00 0x60200000 0x00 0x1fe00000>,

                     <0x43000000 0x18 0x00000000 0x18 0x00000000 0x04 0x00000000>;

            #address-cells = <3>;

            #size-cells = <2>;

            bus-range = <0xc0 0xff>;

            device_type = "pci";

            #interrupt-cells = <1>;

            interrupt-map-mask = <0 0 0 0x7>;

            interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 407 IRQ_TYPE_LEVEL_HIGH 0>,

                            <0 0 0 2 &gic 0 0 GIC_SPI 408 IRQ_TYPE_LEVEL_HIGH 0>,

                            <0 0 0 3 &gic 0 0 GIC_SPI 409 IRQ_TYPE_LEVEL_HIGH 0>,

                            <0 0 0 4 &gic 0 0 GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH 0>;

            msi-map = <0xc000 &gic_its 0xc000 0x4000>;

        };

    };

Documentation/devicetree/bindings/pci/mediatek-pcie-mt7623.yaml

0 → 100644
+164 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

%YAML 1.2

---

$id: http://devicetree.org/schemas/pci/mediatek-pcie-mt7623.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: PCIe controller on MediaTek SoCs



maintainers:

  - Christian Marangi <ansuelsmth@gmail.com>



properties:

  compatible:

    enum:

      - mediatek,mt2701-pcie

      - mediatek,mt7623-pcie



  reg:

    minItems: 4

    maxItems: 4



  reg-names:

    items:

      - const: subsys

      - const: port0

      - const: port1

      - const: port2



  clocks:

    minItems: 4

    maxItems: 4



  clock-names:

    items:

      - const: free_ck

      - const: sys_ck0

      - const: sys_ck1

      - const: sys_ck2



  resets:

    minItems: 3

    maxItems: 3



  reset-names:

    items:

      - const: pcie-rst0

      - const: pcie-rst1

      - const: pcie-rst2



  phys:

    minItems: 3

    maxItems: 3



  phy-names:

    items:

      - const: pcie-phy0

      - const: pcie-phy1

      - const: pcie-phy2



  power-domains:

    maxItems: 1



required:

  - compatible

  - reg

  - reg-names

  - ranges

  - clocks

  - clock-names

  - '#interrupt-cells'

  - resets

  - reset-names

  - phys

  - phy-names

  - power-domains

  - pcie@0,0

  - pcie@1,0

  - pcie@2,0



allOf:

  - $ref: /schemas/pci/pci-host-bridge.yaml#



unevaluatedProperties: false



examples:

  # MT7623

  - |

    #include <dt-bindings/interrupt-controller/arm-gic.h>

    #include <dt-bindings/interrupt-controller/irq.h>

    #include <dt-bindings/clock/mt2701-clk.h>

    #include <dt-bindings/reset/mt2701-resets.h>

    #include <dt-bindings/phy/phy.h>

    #include <dt-bindings/power/mt2701-power.h>



    soc {

        #address-cells = <2>;

        #size-cells = <2>;



        pcie@1a140000 {

            compatible = "mediatek,mt7623-pcie";

            device_type = "pci";

            reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */

                  <0 0x1a142000 0 0x1000>, /* Port0 registers */

                  <0 0x1a143000 0 0x1000>, /* Port1 registers */

                  <0 0x1a144000 0 0x1000>; /* Port2 registers */

            reg-names = "subsys", "port0", "port1", "port2";

            #address-cells = <3>;

            #size-cells = <2>;

            #interrupt-cells = <1>;

            interrupt-map-mask = <0xf800 0 0 0>;

            interrupt-map = <0x0000 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>,

                            <0x0800 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>,

                            <0x1000 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

            clocks = <&topckgen CLK_TOP_ETHIF_SEL>,

                    <&hifsys CLK_HIFSYS_PCIE0>,

                    <&hifsys CLK_HIFSYS_PCIE1>,

                    <&hifsys CLK_HIFSYS_PCIE2>;

            clock-names = "free_ck", "sys_ck0", "sys_ck1", "sys_ck2";

            resets = <&hifsys MT2701_HIFSYS_PCIE0_RST>,

                     <&hifsys MT2701_HIFSYS_PCIE1_RST>,

                     <&hifsys MT2701_HIFSYS_PCIE2_RST>;

            reset-names = "pcie-rst0", "pcie-rst1", "pcie-rst2";

            phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>,

                   <&pcie2_phy PHY_TYPE_PCIE>;

            phy-names = "pcie-phy0", "pcie-phy1", "pcie-phy2";

            power-domains = <&scpsys MT2701_POWER_DOMAIN_HIF>;

            bus-range = <0x00 0xff>;

            ranges = <0x81000000 0 0x1a160000 0 0x1a160000 0 0x00010000>,	/* I/O space */

                     <0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>;	/* memory space */



            pcie@0,0 {

                device_type = "pci";

                reg = <0x0000 0 0 0 0>;

                #address-cells = <3>;

                #size-cells = <2>;

                #interrupt-cells = <1>;

                interrupt-map-mask = <0 0 0 0>;

                interrupt-map = <0 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>;

                ranges;

            };



            pcie@1,0 {

                device_type = "pci";

                reg = <0x0800 0 0 0 0>;

                #address-cells = <3>;

                #size-cells = <2>;

                #interrupt-cells = <1>;

                interrupt-map-mask = <0 0 0 0>;

                interrupt-map = <0 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;

                ranges;

            };



            pcie@2,0 {

                device_type = "pci";

                reg = <0x1000 0 0 0 0>;

                #address-cells = <3>;

                #size-cells = <2>;

                #interrupt-cells = <1>;

                interrupt-map-mask = <0 0 0 0>;

                interrupt-map = <0 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

                ranges;

            };

        };

    };

Documentation/devicetree/bindings/pci/mediatek-pcie.txt

deleted100644 → 0
+0 −289
Original line number Diff line number Diff line 
MediaTek Gen2 PCIe controller



Required properties:

- compatible: Should contain one of the following strings:

	"mediatek,mt2701-pcie"

	"mediatek,mt2712-pcie"

	"mediatek,mt7622-pcie"

	"mediatek,mt7623-pcie"

	"mediatek,mt7629-pcie"

	"airoha,en7523-pcie"

- device_type: Must be "pci"

- reg: Base addresses and lengths of the root ports.

- reg-names: Names of the above areas to use during resource lookup.

- #address-cells: Address representation for root ports (must be 3)

- #size-cells: Size representation for root ports (must be 2)

- clocks: Must contain an entry for each entry in clock-names.

  See ../clocks/clock-bindings.txt for details.

- clock-names:

  Mandatory entries:

   - sys_ckN :transaction layer and data link layer clock

  Required entries for MT2701/MT7623:

   - free_ck :for reference clock of PCIe subsys

  Required entries for MT2712/MT7622:

   - ahb_ckN :AHB slave interface operating clock for CSR access and RC

	      initiated MMIO access

  Required entries for MT7622:

   - axi_ckN :application layer MMIO channel operating clock

   - aux_ckN :pe2_mac_bridge and pe2_mac_core operating clock when

	      pcie_mac_ck/pcie_pipe_ck is turned off

   - obff_ckN :OBFF functional block operating clock

   - pipe_ckN :LTSSM and PHY/MAC layer operating clock

  where N starting from 0 to one less than the number of root ports.

- phys: List of PHY specifiers (used by generic PHY framework).

- phy-names : Must be "pcie-phy0", "pcie-phy1", "pcie-phyN".. based on the

  number of PHYs as specified in *phys* property.

- power-domains: A phandle and power domain specifier pair to the power domain

  which is responsible for collapsing and restoring power to the peripheral.

- bus-range: Range of bus numbers associated with this controller.

- ranges: Ranges for the PCI memory and I/O regions.



Required properties for MT7623/MT2701:

- #interrupt-cells: Size representation for interrupts (must be 1)

- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties

  Please refer to the standard PCI bus binding document for a more detailed

  explanation.

- resets: Must contain an entry for each entry in reset-names.

  See ../reset/reset.txt for details.

- reset-names: Must be "pcie-rst0", "pcie-rst1", "pcie-rstN".. based on the

  number of root ports.



Required properties for MT2712/MT7622/MT7629:

-interrupts: A list of interrupt outputs of the controller, must have one

	     entry for each PCIe port

- interrupt-names: Must include the following entries:

	- "pcie_irq": The interrupt that is asserted when an MSI/INTX is received

- linux,pci-domain: PCI domain ID. Should be unique for each host controller



In addition, the device tree node must have sub-nodes describing each

PCIe port interface, having the following mandatory properties:



Required properties:

- device_type: Must be "pci"

- reg: Only the first four bytes are used to refer to the correct bus number

  and device number.

- #address-cells: Must be 3

- #size-cells: Must be 2

- #interrupt-cells: Must be 1

- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties

  Please refer to the standard PCI bus binding document for a more detailed

  explanation.

- ranges: Sub-ranges distributed from the PCIe controller node. An empty

  property is sufficient.



Examples for MT7623:



	hifsys: syscon@1a000000 {

		compatible = "mediatek,mt7623-hifsys",

			     "mediatek,mt2701-hifsys",

			     "syscon";

		reg = <0 0x1a000000 0 0x1000>;

		#clock-cells = <1>;

		#reset-cells = <1>;

	};



	pcie: pcie@1a140000 {

		compatible = "mediatek,mt7623-pcie";

		device_type = "pci";

		reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */

		      <0 0x1a142000 0 0x1000>, /* Port0 registers */

		      <0 0x1a143000 0 0x1000>, /* Port1 registers */

		      <0 0x1a144000 0 0x1000>; /* Port2 registers */

		reg-names = "subsys", "port0", "port1", "port2";

		#address-cells = <3>;

		#size-cells = <2>;

		#interrupt-cells = <1>;

		interrupt-map-mask = <0xf800 0 0 0>;

		interrupt-map = <0x0000 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>,

				<0x0800 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>,

				<0x1000 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

		clocks = <&topckgen CLK_TOP_ETHIF_SEL>,

			 <&hifsys CLK_HIFSYS_PCIE0>,

			 <&hifsys CLK_HIFSYS_PCIE1>,

			 <&hifsys CLK_HIFSYS_PCIE2>;

		clock-names = "free_ck", "sys_ck0", "sys_ck1", "sys_ck2";

		resets = <&hifsys MT2701_HIFSYS_PCIE0_RST>,

			 <&hifsys MT2701_HIFSYS_PCIE1_RST>,

			 <&hifsys MT2701_HIFSYS_PCIE2_RST>;

		reset-names = "pcie-rst0", "pcie-rst1", "pcie-rst2";

		phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>,

		       <&pcie2_phy PHY_TYPE_PCIE>;

		phy-names = "pcie-phy0", "pcie-phy1", "pcie-phy2";

		power-domains = <&scpsys MT2701_POWER_DOMAIN_HIF>;

		bus-range = <0x00 0xff>;

		ranges = <0x81000000 0 0x1a160000 0 0x1a160000 0 0x00010000	/* I/O space */

			  0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>;	/* memory space */



		pcie@0,0 {

			reg = <0x0000 0 0 0 0>;

			#address-cells = <3>;

			#size-cells = <2>;

			#interrupt-cells = <1>;

			interrupt-map-mask = <0 0 0 0>;

			interrupt-map = <0 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>;

			ranges;

		};



		pcie@1,0 {

			reg = <0x0800 0 0 0 0>;

			#address-cells = <3>;

			#size-cells = <2>;

			#interrupt-cells = <1>;

			interrupt-map-mask = <0 0 0 0>;

			interrupt-map = <0 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;

			ranges;

		};



		pcie@2,0 {

			reg = <0x1000 0 0 0 0>;

			#address-cells = <3>;

			#size-cells = <2>;

			#interrupt-cells = <1>;

			interrupt-map-mask = <0 0 0 0>;

			interrupt-map = <0 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

			ranges;

		};

	};



Examples for MT2712:



	pcie1: pcie@112ff000 {

		compatible = "mediatek,mt2712-pcie";

		device_type = "pci";

		reg = <0 0x112ff000 0 0x1000>;

		reg-names = "port1";

		linux,pci-domain = <1>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;

		interrupt-names = "pcie_irq";

		clocks = <&topckgen CLK_TOP_PE2_MAC_P1_SEL>,

			 <&pericfg CLK_PERI_PCIE1>;

		clock-names = "sys_ck1", "ahb_ck1";

		phys = <&u3port1 PHY_TYPE_PCIE>;

		phy-names = "pcie-phy1";

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x11400000  0x0 0x11400000  0 0x300000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc1 0>,

				<0 0 0 2 &pcie_intc1 1>,

				<0 0 0 3 &pcie_intc1 2>,

				<0 0 0 4 &pcie_intc1 3>;

		pcie_intc1: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};



	pcie0: pcie@11700000 {

		compatible = "mediatek,mt2712-pcie";

		device_type = "pci";

		reg = <0 0x11700000 0 0x1000>;

		reg-names = "port0";

		linux,pci-domain = <0>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;

		interrupt-names = "pcie_irq";

		clocks = <&topckgen CLK_TOP_PE2_MAC_P0_SEL>,

			 <&pericfg CLK_PERI_PCIE0>;

		clock-names = "sys_ck0", "ahb_ck0";

		phys = <&u3port0 PHY_TYPE_PCIE>;

		phy-names = "pcie-phy0";

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc0 0>,

				<0 0 0 2 &pcie_intc0 1>,

				<0 0 0 3 &pcie_intc0 2>,

				<0 0 0 4 &pcie_intc0 3>;

		pcie_intc0: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};



Examples for MT7622:



	pcie0: pcie@1a143000 {

		compatible = "mediatek,mt7622-pcie";

		device_type = "pci";

		reg = <0 0x1a143000 0 0x1000>;

		reg-names = "port0";

		linux,pci-domain = <0>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_LOW>;

		interrupt-names = "pcie_irq";

		clocks = <&pciesys CLK_PCIE_P0_MAC_EN>,

			 <&pciesys CLK_PCIE_P0_AHB_EN>,

			 <&pciesys CLK_PCIE_P0_AUX_EN>,

			 <&pciesys CLK_PCIE_P0_AXI_EN>,

			 <&pciesys CLK_PCIE_P0_OBFF_EN>,

			 <&pciesys CLK_PCIE_P0_PIPE_EN>;

		clock-names = "sys_ck0", "ahb_ck0", "aux_ck0",

			      "axi_ck0", "obff_ck0", "pipe_ck0";



		power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>;

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x20000000  0x0 0x20000000  0 0x8000000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc0 0>,

				<0 0 0 2 &pcie_intc0 1>,

				<0 0 0 3 &pcie_intc0 2>,

				<0 0 0 4 &pcie_intc0 3>;

		pcie_intc0: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};



	pcie1: pcie@1a145000 {

		compatible = "mediatek,mt7622-pcie";

		device_type = "pci";

		reg = <0 0x1a145000 0 0x1000>;

		reg-names = "port1";

		linux,pci-domain = <1>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;

		interrupt-names = "pcie_irq";

		clocks = <&pciesys CLK_PCIE_P1_MAC_EN>,

			 /* designer has connect RC1 with p0_ahb clock */

			 <&pciesys CLK_PCIE_P0_AHB_EN>,

			 <&pciesys CLK_PCIE_P1_AUX_EN>,

			 <&pciesys CLK_PCIE_P1_AXI_EN>,

			 <&pciesys CLK_PCIE_P1_OBFF_EN>,

			 <&pciesys CLK_PCIE_P1_PIPE_EN>;

		clock-names = "sys_ck1", "ahb_ck1", "aux_ck1",

			      "axi_ck1", "obff_ck1", "pipe_ck1";



		power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>;

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x28000000  0x0 0x28000000  0 0x8000000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc1 0>,

				<0 0 0 2 &pcie_intc1 1>,

				<0 0 0 3 &pcie_intc1 2>,

				<0 0 0 4 &pcie_intc1 3>;

		pcie_intc1: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};