Commit 43fb9e11 authored by Raag Jadav's avatar Raag Jadav Committed by Ashutosh Dixit
Browse files

drm/xe/gt: Introduce runtime suspend/resume 



If power state is retained between suspend/resume cycle, we don't need
to perform full GT re-initialization. Introduce runtime helpers for GT
which greatly reduce suspend/resume delay.

v2: Drop redundant xe_gt_sanitize() and xe_guc_ct_stop() (Daniele)
    Use runtime naming for guc helpers (Daniele)
v3: Drop redundant logging, add kernel doc (Michal)
    Use runtime naming for ct helpers (Michal)
v4: Fix tags (Rodrigo)
v5: Include host_l2_vram workaround (Daniele)
    Reuse xe_guc_submit_enable/disable() helpers (Daniele)

Co-developed-by: default avatarRiana Tauro <riana.tauro@intel.com>
Signed-off-by: default avatarRiana Tauro <riana.tauro@intel.com>
Signed-off-by: default avatarRaag Jadav <raag.jadav@intel.com>
Acked-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarAshutosh Dixit <ashutosh.dixit@intel.com>
Link: https://patch.msgid.link/20251030122357.128825-5-raag.jadav@intel.com
parent e6d2fe31

drivers/gpu/drm/xe/xe_gt.c

+60 −0
Original line number Diff line number Diff line
@@ -956,6 +956,66 @@ int xe_gt_resume(struct xe_gt *gt) 
	return 0;

}



/**

 * xe_gt_runtime_suspend() - GT runtime suspend

 * @gt: the GT object

 *

 * Return: 0 on success, negative error code otherwise.

 */

int xe_gt_runtime_suspend(struct xe_gt *gt)

{

	unsigned int fw_ref;

	int err = -ETIMEDOUT;



	xe_gt_dbg(gt, "runtime suspending\n");



	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);

	if (!xe_force_wake_ref_has_domain(fw_ref, XE_FORCEWAKE_ALL))

		goto err_force_wake;



	xe_uc_runtime_suspend(&gt->uc);

	xe_gt_disable_host_l2_vram(gt);



	xe_force_wake_put(gt_to_fw(gt), fw_ref);

	xe_gt_dbg(gt, "runtime suspended\n");



	return 0;



err_force_wake:

	xe_force_wake_put(gt_to_fw(gt), fw_ref);

	return err;

}



/**

 * xe_gt_runtime_resume() - GT runtime resume

 * @gt: the GT object

 *

 * Return: 0 on success, negative error code otherwise.

 */

int xe_gt_runtime_resume(struct xe_gt *gt)

{

	unsigned int fw_ref;

	int err = -ETIMEDOUT;



	xe_gt_dbg(gt, "runtime resuming\n");



	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);

	if (!xe_force_wake_ref_has_domain(fw_ref, XE_FORCEWAKE_ALL))

		goto err_force_wake;



	xe_gt_enable_host_l2_vram(gt);

	xe_uc_runtime_resume(&gt->uc);



	xe_force_wake_put(gt_to_fw(gt), fw_ref);

	xe_gt_dbg(gt, "runtime resumed\n");



	return 0;



err_force_wake:

	xe_force_wake_put(gt_to_fw(gt), fw_ref);

	return err;

}



struct xe_hw_engine *xe_gt_hw_engine(struct xe_gt *gt,

				     enum xe_engine_class class,

				     u16 instance, bool logical)

drivers/gpu/drm/xe/xe_gt.h

+2 −0
Original line number Diff line number Diff line
@@ -58,6 +58,8 @@ int xe_gt_suspend(struct xe_gt *gt); 
void xe_gt_shutdown(struct xe_gt *gt);

int xe_gt_resume(struct xe_gt *gt);

void xe_gt_reset_async(struct xe_gt *gt);

int xe_gt_runtime_resume(struct xe_gt *gt);

int xe_gt_runtime_suspend(struct xe_gt *gt);

void xe_gt_sanitize(struct xe_gt *gt);

int xe_gt_sanitize_freq(struct xe_gt *gt);

drivers/gpu/drm/xe/xe_guc.c

+34 −0
Original line number Diff line number Diff line
@@ -1617,6 +1617,40 @@ int xe_guc_start(struct xe_guc *guc) 
	return xe_guc_submit_start(guc);

}



/**

 * xe_guc_runtime_suspend() - GuC runtime suspend

 * @guc: The GuC object

 *

 * Stop further runs of submission tasks on given GuC and runtime suspend

 * GuC CT.

 */

void xe_guc_runtime_suspend(struct xe_guc *guc)

{

	xe_guc_submit_pause(guc);

	xe_guc_submit_disable(guc);

	xe_guc_ct_runtime_suspend(&guc->ct);

}



/**

 * xe_guc_runtime_resume() - GuC runtime resume

 * @guc: The GuC object

 *

 * Runtime resume GuC CT and allow further runs of submission tasks on

 * given GuC.

 */

void xe_guc_runtime_resume(struct xe_guc *guc)

{

	/*

	 * Runtime PM flows are not applicable for VFs, so it's safe to

	 * directly enable IRQ.

	 */

	guc_enable_irq(guc);



	xe_guc_ct_runtime_resume(&guc->ct);

	xe_guc_submit_enable(guc);

	xe_guc_submit_unpause(guc);

}



void xe_guc_print_info(struct xe_guc *guc, struct drm_printer *p)

{

	struct xe_gt *gt = guc_to_gt(guc);

drivers/gpu/drm/xe/xe_guc.h

+2 −0
Original line number Diff line number Diff line
@@ -35,6 +35,8 @@ int xe_guc_upload(struct xe_guc *guc); 
int xe_guc_min_load_for_hwconfig(struct xe_guc *guc);

int xe_guc_enable_communication(struct xe_guc *guc);

int xe_guc_opt_in_features_enable(struct xe_guc *guc);

void xe_guc_runtime_suspend(struct xe_guc *guc);

void xe_guc_runtime_resume(struct xe_guc *guc);

int xe_guc_suspend(struct xe_guc *guc);

void xe_guc_notify(struct xe_guc *guc);

int xe_guc_auth_huc(struct xe_guc *guc, u32 rsa_addr);

drivers/gpu/drm/xe/xe_guc_ct.c

+27 −0
Original line number Diff line number Diff line
@@ -717,6 +717,33 @@ void xe_guc_ct_stop(struct xe_guc_ct *ct) 
	stop_g2h_handler(ct);

}



/**

 * xe_guc_ct_runtime_suspend() - GuC CT runtime suspend

 * @ct: the &xe_guc_ct

 *

 * Set GuC CT to disabled state.

 */

void xe_guc_ct_runtime_suspend(struct xe_guc_ct *ct)

{

	/*

	 * Since we're already in runtime suspend path, we shouldn't have pending

	 * messages. But if there happen to be any, we'd probably want them to be

	 * thrown as errors for further investigation.

	 */

	xe_guc_ct_disable(ct);

}



/**

 * xe_guc_ct_runtime_resume() - GuC CT runtime resume

 * @ct: the &xe_guc_ct

 *

 * Restart GuC CT and set it to enabled state.

 */

void xe_guc_ct_runtime_resume(struct xe_guc_ct *ct)

{

	xe_guc_ct_restart(ct);

}



static bool h2g_has_room(struct xe_guc_ct *ct, u32 cmd_len)

{

	struct guc_ctb *h2g = &ct->ctbs.h2g;