Commit 4406e417 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix off by one in qla_edif_app_getstats() 



The app_reply->elem[] array is allocated earlier in this function and it
has app_req.num_ports elements.  Thus this > comparison needs to be >= to
prevent memory corruption.

Fixes: 7878f22a ("scsi: qla2xxx: edif: Add getfcinfo and statistic bsgs")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/5c125b2f-92dd-412b-9b6f-fc3a3207bd60@moroto.mountain


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0098c55e

drivers/scsi/qla2xxx/qla_edif.c

+1 −1
Original line number Diff line number Diff line
@@ -1100,7 +1100,7 @@ qla_edif_app_getstats(scsi_qla_host_t *vha, struct bsg_job *bsg_job) 


		list_for_each_entry_safe(fcport, tf, &vha->vp_fcports, list) {

			if (fcport->edif.enable) {

				if (pcnt > app_req.num_ports)

				if (pcnt >= app_req.num_ports)

					break;



				app_reply->elem[pcnt].rekey_count =