Commit 44348870 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: fix the blk_queue_nonrot polarity 



Take care of the inverse polarity of the BLK_FEAT_ROTATIONAL flag
vs the old nonrot helper.

Fixes: bd4a633b ("block: move the nonrot flag to queue_limits")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Reported-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240624173835.76753-1-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 876835b1

include/linux/blkdev.h

+1 −1
Original line number Diff line number Diff line
@@ -617,7 +617,7 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q); 
#define blk_queue_nomerges(q)	test_bit(QUEUE_FLAG_NOMERGES, &(q)->queue_flags)

#define blk_queue_noxmerges(q)	\

	test_bit(QUEUE_FLAG_NOXMERGES, &(q)->queue_flags)

#define blk_queue_nonrot(q)	((q)->limits.features & BLK_FEAT_ROTATIONAL)

#define blk_queue_nonrot(q)	(!((q)->limits.features & BLK_FEAT_ROTATIONAL))

#define blk_queue_io_stat(q)	((q)->limits.features & BLK_FEAT_IO_STAT)

#define blk_queue_zone_resetall(q)	\

	((q)->limits.features & BLK_FEAT_ZONE_RESETALL)