Commit 44382b3e authored by Natalie Vock's avatar Natalie Vock Committed by Daniel Borkmann
Browse files

bpf: Fix potential integer overflow in resolve_btfids 



err is a 32-bit integer, but elf_update returns an off_t, which is 64-bit
at least on 64-bit platforms. If symbols_patch is called on a binary between
2-4GB in size, the result will be negative when cast to a 32-bit integer,
which the code assumes means an error occurred. This can wrongly trigger
build failures when building very large kernel images.

Fixes: fbbb68de ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Signed-off-by: default avatarFriedrich Vock <friedrich.vock@gmx.de>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20240514070931.199694-1-friedrich.vock@gmx.de
parent 8d00547e

tools/bpf/resolve_btfids/main.c

+1 −1
Original line number Diff line number Diff line
@@ -728,7 +728,7 @@ static int sets_patch(struct object *obj) 


static int symbols_patch(struct object *obj)

{

	int err;

	off_t err;



	if (__symbols_patch(obj, &obj->structs)  ||

	    __symbols_patch(obj, &obj->unions)   ||