Commit 4444e4d7 authored Feb 21, 2025 by Heiko Stuebner

drm/rockchip: Fix shutdown when no drm-device is set up

When the drm-driver probes, it mainly creates the component device, where
all the sub-drivers (vops, hdmi, etc) hook into.

This will cause the shutdown handler to get called on shutdown, even
though the drm-device might not have been set up, or the component bind
might have failed.

So use the new component helper to check whether the drm-device is up
and only then call the drm-atomic helper to release all the drm magic.

This prevents failures when the drm-device is never set, or has been
freed up already for example by a probe-defer during the component bind.

Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20250220234141.2788785-3-heiko@sntech.de

parent a6ba2dad

drivers/gpu/drm/rockchip/rockchip_drm_drv.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -484,10 +484,12 @@ static void rockchip_drm_platform_remove(struct platform_device *pdev)

		static void rockchip_drm_platform_shutdown(struct platform_device *pdev)
		{
		if (component_master_is_bound(&pdev->dev, &rockchip_drm_ops)) {
		struct drm_device *drm = platform_get_drvdata(pdev);

		drm_atomic_helper_shutdown(drm);
		}
		}

		static const struct of_device_id rockchip_drm_dt_ids[] = {
		{ .compatible = "rockchip,display-subsystem", },