Commit 444a43bf authored by Anand Moon's avatar Anand Moon Committed by Bjorn Helgaas
Browse files

PCI: j721e: Use 'pcie->reset_gpio' directly and drop the local variable 



Assign the result of devm_gpiod_get_optional() directly to
pcie->reset_gpio, thereby removing the local variable.

Signed-off-by: default avatarAnand Moon <linux.amoon@gmail.com>
Signed-off-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarSiddharth Vadapalli <s-vadapalli@ti.com>
Link: https://patch.msgid.link/20251028154229.6774-3-linux.amoon@gmail.com
parent 6fad11c6

drivers/pci/controller/cadence/pci-j721e.c

+6 −7
Original line number Diff line number Diff line
@@ -477,7 +477,6 @@ static int j721e_pcie_probe(struct platform_device *pdev) 
	struct j721e_pcie *pcie;

	struct cdns_pcie_rc *rc = NULL;

	struct cdns_pcie_ep *ep = NULL;

	struct gpio_desc *gpiod;

	void __iomem *base;

	u32 num_lanes;

	u32 mode;
@@ -589,12 +588,12 @@ static int j721e_pcie_probe(struct platform_device *pdev) 


	switch (mode) {

	case PCI_MODE_RC:

		gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);

		if (IS_ERR(gpiod)) {

			ret = dev_err_probe(dev, PTR_ERR(gpiod), "Failed to get reset GPIO\n");

		pcie->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);

		if (IS_ERR(pcie->reset_gpio)) {

			ret = dev_err_probe(dev, PTR_ERR(pcie->reset_gpio),

					    "Failed to get reset GPIO\n");

			goto err_get_sync;

		}

		pcie->reset_gpio = gpiod;



		ret = cdns_pcie_init_phy(dev, cdns_pcie);

		if (ret) {
@@ -616,9 +615,9 @@ static int j721e_pcie_probe(struct platform_device *pdev) 
		 * This shall ensure that the power and the reference clock

		 * are stable.

		 */

		if (gpiod) {

		if (pcie->reset_gpio) {

			msleep(PCIE_T_PVPERL_MS);

			gpiod_set_value_cansleep(gpiod, 1);

			gpiod_set_value_cansleep(pcie->reset_gpio, 1);

		}



		ret = cdns_pcie_host_setup(rc);