Commit 44684902 authored by Markus Elfring's avatar Markus Elfring Committed by Steve French
Browse files

smb: client: Return directly after a failed genlmsg_new() in cifs_swn_send_register_message() 



MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Return directly after a call of the function “genlmsg_new” failed
  at the beginning.

* Delete the label “fail” which became unnecessary
  with this refactoring.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent ce47f749

fs/smb/client/cifs_swn.c

+2 −5
Original line number Diff line number Diff line
@@ -82,10 +82,8 @@ static int cifs_swn_send_register_message(struct cifs_swn_reg *swnreg) 
	int ret;



	skb = genlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);

	if (skb == NULL) {

		ret = -ENOMEM;

		goto fail;

	}

	if (!skb)

		return -ENOMEM;



	hdr = genlmsg_put(skb, 0, 0, &cifs_genl_family, 0, CIFS_GENL_CMD_SWN_REGISTER);

	if (hdr == NULL) {
@@ -172,7 +170,6 @@ static int cifs_swn_send_register_message(struct cifs_swn_reg *swnreg) 
nlmsg_fail:

	genlmsg_cancel(skb, hdr);

	nlmsg_free(skb);

fail:

	return ret;

}