Commit 446d2858 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij
Browse files

pinctrl: mediatek: common-v1: Fix error checking in mtk_eint_init() 



The devm_kzalloc() function doesn't return error pointers, it returns
NULL on error.  Then on the next line it checks the same pointer again
by mistake, "->base" instead of "->base[0]".

Fixes: fe412e3a ("pinctrl: mediatek: common-v1: Fix EINT breakage on older controllers")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/aAijc10fHka1WAMX@stanley.mountain


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 34024cf6

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+3 −3
Original line number Diff line number Diff line
@@ -1018,12 +1018,12 @@ static int mtk_eint_init(struct mtk_pinctrl *pctl, struct platform_device *pdev) 
	pctl->eint->nbase = 1;

	/* mtk-eint expects an array */

	pctl->eint->base = devm_kzalloc(pctl->dev, sizeof(pctl->eint->base), GFP_KERNEL);

	if (IS_ERR(pctl->eint->base))

	if (!pctl->eint->base)

		return -ENOMEM;



	pctl->eint->base[0] = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(pctl->eint->base))

		return PTR_ERR(pctl->eint->base);

	if (IS_ERR(pctl->eint->base[0]))

		return PTR_ERR(pctl->eint->base[0]);



	pctl->eint->irq = irq_of_parse_and_map(np, 0);

	if (!pctl->eint->irq)