Commit 44748065 authored by Rob Herring (Arm)'s avatar Rob Herring (Arm)
Browse files

of/unittest: Add test that of_address_to_resource() fails on non-translatable address 

of_address_to_resource() on a non-translatable address should return an
error. Additionally, this case also triggers a spurious WARN for
missing #address-cells/#size-cells.

Link: https://lore.kernel.org/r/20250110215030.3637845-1-robh@kernel.org


Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent 8600058b

drivers/of/unittest-data/tests-platform.dtsi

+13 −0
Original line number Diff line number Diff line
@@ -34,5 +34,18 @@ dev@100 { 
				};

			};

		};



		platform-tests-2 {

			// No #address-cells or #size-cells

			node {

				#address-cells = <1>;

				#size-cells = <1>;



				test-device@100 {

					compatible = "test-sub-device";

					reg = <0x100 1>;

				};

			};

		};

	};

};

drivers/of/unittest.c

+14 −0
Original line number Diff line number Diff line
@@ -1380,6 +1380,7 @@ static void __init of_unittest_bus_3cell_ranges(void) 
static void __init of_unittest_reg(void)

{

	struct device_node *np;

	struct resource res;

	int ret;

	u64 addr, size;
@@ -1396,6 +1397,19 @@ static void __init of_unittest_reg(void) 
		np, addr);



	of_node_put(np);



	np = of_find_node_by_path("/testcase-data/platform-tests-2/node/test-device@100");

	if (!np) {

		pr_err("missing testcase data\n");

		return;

	}



	ret = of_address_to_resource(np, 0, &res);

	unittest(ret == -EINVAL, "of_address_to_resource(%pOF) expected error on untranslatable address\n",

		 np);



	of_node_put(np);



}



struct of_unittest_expected_res {