Commit 448dfecc authored by John Garry's avatar John Garry Committed by Jens Axboe
Browse files

block: avoid possible overflow for chunk_sectors check in blk_stack_limits() 



In blk_stack_limits(), we check that the t->chunk_sectors value is a
multiple of the t->physical_block_size value.

However, by finding the chunk_sectors value in bytes, we may overflow
the unsigned int which holds chunk_sectors, so change the check to be
based on sectors.

Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarJohn Garry <john.g.garry@oracle.com>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250729091448.1691334-2-john.g.garry@oracle.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 459779d0

block/blk-settings.c

+1 −1
Original line number Diff line number Diff line
@@ -857,7 +857,7 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b, 
	}



	/* chunk_sectors a multiple of the physical block size? */

	if ((t->chunk_sectors << 9) & (t->physical_block_size - 1)) {

	if (t->chunk_sectors % (t->physical_block_size >> SECTOR_SHIFT)) {

		t->chunk_sectors = 0;

		t->flags |= BLK_FLAG_MISALIGNED;

		ret = -1;