Commit 44c25333 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

pinctrl: cy8c95x0: Remove device initialization 



The Cypress CY8C95x0 chips have an internal EEPROM that defines
initial configuration. It might be that bootloader or other
entity wrote the platform related setup into it. Don't override
it in the driver.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarPatrick Rudolph <patrick.rudolph@9elements.com>
Link: https://lore.kernel.org/r/20220902182650.83098-8-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent d86e0344

drivers/pinctrl/pinctrl-cy8c95x0.c

+0 −28
Original line number Diff line number Diff line
@@ -1224,30 +1224,6 @@ static int cy8c95x0_setup_pinctrl(struct cy8c95x0_pinctrl *chip) 
	return 0;

}



static int device_cy8c95x0_init(struct cy8c95x0_pinctrl *chip)

{

	DECLARE_BITMAP(ones, MAX_LINE);

	DECLARE_BITMAP(zeros, MAX_LINE);

	int ret;



	/* Set all pins to input. This is the POR default. */

	bitmap_fill(ones, MAX_LINE);

	ret = cy8c95x0_write_regs_mask(chip, CY8C95X0_DIRECTION, ones, ones);

	if (ret) {

		dev_err(chip->dev, "Failed to set pins to input\n");

		return ret;

	}



	bitmap_zero(zeros, MAX_LINE);

	ret = cy8c95x0_write_regs_mask(chip, CY8C95X0_INVERT, zeros, ones);

	if (ret) {

		dev_err(chip->dev, "Failed to set polarity inversion\n");

		return ret;

	}



	return 0;

}



static int cy8c95x0_detect(struct i2c_client *client,

			   struct i2c_board_info *info)

{
@@ -1343,10 +1319,6 @@ static int cy8c95x0_probe(struct i2c_client *client) 
	bitmap_set(chip->shiftmask, 0, 20);

	mutex_init(&chip->i2c_lock);



	ret = device_cy8c95x0_init(chip);

	if (ret)

		goto err_exit;



	if (client->irq) {

		ret = cy8c95x0_irq_setup(chip, client->irq);

		if (ret)