Commit 457bb797 authored by Ales Nezbeda's avatar Ales Nezbeda Committed by David S. Miller
Browse files

net: macsec: Add endianness annotations in salt struct 



This change resolves warning produced by sparse tool as currently
there is a mismatch between normal generic type in salt and endian
annotated type in macsec driver code. Endian annotated types should
be used here.

Sparse output:
warning: restricted ssci_t degrades to integer
warning: incorrect type in assignment (different base types)
    expected restricted ssci_t [usertype] ssci
    got unsigned int
warning: restricted __be64 degrades to integer
warning: incorrect type in assignment (different base types)
    expected restricted __be64 [usertype] pn
    got unsigned long long

Signed-off-by: default avatarAles Nezbeda <anezbeda@redhat.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5fe71fda

include/net/macsec.h

+2 −2
Original line number Diff line number Diff line
@@ -38,8 +38,8 @@ struct metadata_dst; 


typedef union salt {

	struct {

		u32 ssci;

		u64 pn;

		ssci_t ssci;

		__be64 pn;

	} __packed;

	u8 bytes[MACSEC_SALT_LEN];

} __packed salt_t;